Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpak: 1.6.2 -> 1.6.3 #83781

Merged
merged 1 commit into from Mar 31, 2020
Merged

flatpak: 1.6.2 -> 1.6.3 #83781

merged 1 commit into from Mar 31, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Mar 30, 2020

https://github.com/flatpak/flatpak/releases/tag/1.6.3

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable, we are not affected by the bubblewrap vulnerability.

@jtojnar jtojnar added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 30, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Mar 31, 2020

Successfully ran the installed tests locally using nix run -f . gnome-desktop-testing ostree -c gnome-desktop-testing-runner -d $(nix-build -A flatpak.installedTests --no-out-link)/share.

@jtojnar jtojnar merged commit 648327d into NixOS:master Mar 31, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Mar 31, 2020

Thanks. Backported in

[release-20.03 b57eabee9fd] flatpak: 1.6.2 -> 1.6.3
 Author: zowoq <59103226+zowoq@users.noreply.github.com>
 Date: Tue Mar 31 00:36:30 2020 +1000
 1 file changed, 2 insertions(+), 2 deletions(-)

@jtojnar jtojnar removed the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 31, 2020
@zowoq zowoq deleted the flatpak branch March 31, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants