Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

robustirc-bridge: init at 1.8 #83780

Merged
merged 3 commits into from Aug 31, 2020
Merged

robustirc-bridge: init at 1.8 #83780

merged 3 commits into from Aug 31, 2020

Conversation

hax404
Copy link
Contributor

@hax404 hax404 commented Mar 30, 2020

Motivation for this change

add robustirc-bridge for connecting to RobustIRC Networks

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hax404 hax404 requested a review from infinisil as a code owner March 30, 2020 14:37
@andir
Copy link
Member

andir commented Mar 31, 2020

@GrahamcOfBorg eval

doronbehar
doronbehar reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that LGTM.

pkgs/servers/irc/robustirc-bridge/default.nix Outdated Show resolved Hide resolved
pkgs/servers/irc/robustirc-bridge/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from kalbasit April 6, 2020 11:07
doronbehar
doronbehar approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested to build as far as --help is concerned.

@hax404
Copy link
Contributor Author

hax404 commented Aug 23, 2020

Rebased on master and updated to use vendorSha256 instead of modSha256.

@Lassulus
Copy link
Member

hey, maybe it would be cooler to split this into 2 commits? one for the package one for the service? new services are also encouraged to have a test with them

@hax404
Copy link
Contributor Author

hax404 commented Aug 30, 2020

As @Lassulus suggested, i split the commit and added a test to check if the services comes up.

@Lassulus Lassulus merged commit a081e99 into NixOS:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus left review comments

@doronbehar doronbehar doronbehar approved these changes

@infinisil infinisil Awaiting requested review from infinisil

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hax404 @andir @Lassulus @doronbehar