-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Package ruby-debug-ide #83779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package ruby-debug-ide #83779
Conversation
This is the error I am getting when I try to build
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Why does it fail to build the native extension? Is there an error message for that somehow? |
The issue is that the |
I tried using a local version of Also, it seems like This might be part of the issue. |
Indeed.
|
I added debase to the default set of gems by adding it to the gemfile in
with-packages. I managed to import it in a ruby repl.
Does that affect your suggestion?
…On Mon., Mar. 30, 2020, 12:00 p.m. zimbatm, ***@***.***> wrote:
Indeed. debase probably needs to be added to the ruby-debug-ide
buildInputs. This scenario is not super well supported. Basically you want
package debase, then inject it back into the bundlerApp useing the
gemConfig attribute.
{ bundlerApp, defaultGemConfig
, debase // Packaged separately.
}:
bundlerApp {
gemConfig = defaultGemConfig // {
ruby-debug-ide = attrs: {
buildInputs = [ debase ];
};
};
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#83779 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7J7B5ZCK44ELPMBL5QYTRKC6ZXANCNFSM4LWULGOA>
.
|
Since I added
That still didn't work... |
Another question, how do I set an environment variable before the build? I tried doing this:
I tried doing this
(i added a |
Edit: even faster if you can find some documentation I guess. The fastest way until someone replies might be to start digging down into the source of bundlerApp. If it's mkDerivation based, then any extra variables you set in the arguments of bundlerApp should be passed as environment variables, and will be there for the entirety of the build process (modulo and mutations that happen inside of course). I guess this might be easier to test empirically than to dig in the source though. Furthermore, I think function application binds stronger than You can play in
|
I've been reading a lot of the internal code to figure things out. Thanks for the hint re |
Hmm, yeah, as far as I can tell it looks like you're right. I'm not sure why it's like that. Maybe there's another way, or its due for a fix :) or it's not supposed to be used like that for some reason? |
Actually, can you |
I tried that, no luck. |
Well, you can inspect the resulting derivation with
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
Motivation for this change
Allow ruby devs using Nix to use their preferred IDE to debug their projects.
ruby-debug-ide
is used by VS Code and RubyMine for debugging.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)