Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxml2: add patch for CVE-2019-20388 #82418

Merged
merged 1 commit into from Mar 12, 2020
Merged

libxml2: add patch for CVE-2019-20388 #82418

merged 1 commit into from Mar 12, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Mar 12, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    • there's about 12000 of them:(
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata mmilata changed the base branch from master to staging March 12, 2020 20:05
@mmilata
Copy link
Member Author

mmilata commented Mar 12, 2020

Rebased to staging due to large number of dependent packages.

@ofborg ofborg bot requested a review from edolstra March 12, 2020 20:26
@alyssais alyssais merged commit 291c735 into NixOS:staging Mar 12, 2020
@mmilata mmilata deleted the libxml2-cve-20388 branch March 12, 2020 23:46
@vcunat vcunat mentioned this pull request Mar 15, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@ttuegel ttuegel Awaiting requested review from ttuegel

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmilata @alyssais