Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.WakaTime.vscode-wakatime: prefer local wakatime #82417

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Mar 12, 2020

Motivation for this change

Use the wakatime in the extension directory. Or if you put standalone = false in the wakatime config but that's unnecessary work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu
Copy link
Member Author

eadwu commented Mar 16, 2020

Seems to block the download of the standalone cli but extension is still broken.

Right now the recommended fix editing the config file of Wakatime to set standalone = false.

@eadwu eadwu closed this Mar 16, 2020
@eadwu eadwu deleted the vscode-extensions.WakaTime.vscode-wakatime/prefer-local-wakatime branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant