Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dwarf-fortress: 0.47.02 -> 0.47.04 #82431

Merged
merged 2 commits into from Mar 13, 2020
Merged

dwarf-fortress: 0.47.02 -> 0.47.04 #82431

merged 2 commits into from Mar 13, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 12, 2020 •
edited

Motivation for this change

lots of bug fixes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from a user March 12, 2020 18:47
@jonringer
Copy link
Contributor Author

cc @shazow

@ofborg ofborg bot requested review from abbradar, the-kenny and bendlas March 12, 2020 19:05
@ghost
Copy link

ghost commented Mar 13, 2020

LGTM 👍

shazow
shazow approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@shazow shazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't had a chance to try it yet but the diff looks good.

@jonringer
Copy link
Contributor Author 

[4 built]
https://github.com/NixOS/nixpkgs/pull/82431
5 package built:
dwarf-fortress dwarf-fortress-packages.dwarf-fortress-full dwarf-fortress-packages.dwarf-fortress-original dwarf-therapist dwarf-fortress-packages.dwarf-therapist-original

@jonringer jonringer merged commit c9f216d into NixOS:master Mar 13, 2020
@jonringer jonringer deleted the bump-dwarf-fortress-47.4 branch March 13, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazow shazow shazow approved these changes

@abbradar abbradar Awaiting requested review from abbradar

@the-kenny the-kenny Awaiting requested review from the-kenny

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @shazow