afl: Fix afl-qemu build by applying new patches #82432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamilaBorowska
suggested changes
Mar 13, 2020
These patches are gathered from different sources, such as https://patchwork.kernel.org/patch/10862231/ for the `gettid` patch. Another patch comes from the issue in the AFL repository. The ultimate goal is to get these patches upstream as well, so we don't keep these general patches only within nixos. A PR is created against Google/AFL google/AFL#79, but it might take a while before it's landed, considering the history of the project (there are more PRs open). ZHF: NixOS#80379 Fixes issue NixOS#82232
Mindavi
force-pushed
the
bugfix/afl-qemu-build
branch
from
e59408a
to
1a73774
Compare
|
I like that better too, copying the original patch over is nonsense. |
KamilaBorowska
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches are gathered from different sources,
such as https://patchwork.kernel.org/patch/10862231/ for the
gettidpatch.Another patch comes from the issue in the AFL repository.
The ultimate goal is to get these patches upstream as well,
so we don't keep these general patches only within nixos.
A PR is created against Google/AFL
google/AFL#79,
but it might take a while before it's landed, considering the history
of the project (there are more PRs open).
ZHF: #80379
Fixes issue #82232
Motivation for this change
Zero hydra failures, and I want to be able to use AFL without manually patching out the QEMU support from my local nixpkgs repository. I'm not using QEMU, but could imagine others wanting to use it.
Another solution might be dropping support for the qemu-mode, but I think keeping it is preferable.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)