ci: init #1251
Merged
ci: init #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `ci.nix` which is able to generate a `ci.yml` for use with github actions. Usage: `nix-build ci.nix --no-out-link | bash` The main idea behind generating the yaml with nix, as opposed to just writing yaml, is that Nix is easier to write and maintain. It would've taken a lot more copy-paste to achieve the same done here in raw gh actions yaml.
bjornfor
reviewed
Mar 12, 2020
| }]; | ||
| build = mkJob [{ | ||
| name = "Build"; | ||
| run = "nix-build --quiet release.nix -A build.x86_64-linux -I nixpkgs=channel:19.09"; |
There was a problem hiding this comment.
Since release.nix already has a default nixpkgs, isn't adding -I nixpkgs=... asking for trouble?
There was a problem hiding this comment.
This was copied over from .travis.yml
bjornfor
reviewed
Mar 12, 2020
| run = '' | ||
| cp ${ciPath} /tmp/ci.reference.yml | ||
| nix-build ci.nix --no-out-link | bash | ||
| diff ${ciPath} /tmp/ci.reference.yml || exit 1 |
There was a problem hiding this comment.
The generated yml/json file is one long line. Perhaps prettifying it with jq makes it more readable and results in easier to read diffs?
There was a problem hiding this comment.
Deferring to @grahamc, I'd be fine with that
|
Not sure this is a good idea. The generated file may be more verbose, but it's easier to understand. E.g. if I now need to change something to the GitHub actions, I have to figure out exactly what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
ci.nixwhich is able to generate aci.ymlfor use withgithub actions.
Usage:
nix-build ci.nix --no-out-link | bashThe main idea behind generating the yaml with nix, as opposed to just
writing yaml, is that Nix is easier to write and maintain. It would've
taken a lot more copy-paste to achieve the same done here in raw gh
actions yaml.