Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 12.8.5 -> 12.8.6 #82374

Merged
merged 3 commits into from Mar 12, 2020
Merged

gitlab: 12.8.5 -> 12.8.6 #82374

merged 3 commits into from Mar 12, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Mar 12, 2020

Motivation for this change

https://about.gitlab.com/releases/2020/03/11/critical-security-release-gitlab-12-dot-8-dot-6-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested review from fpletz, globin, a user and Ma27 March 12, 2020 02:01
@flokli flokli added 9.needs: port to stable A PR needs a backport to the stable release. 1.severity: security labels Mar 12, 2020
@flokli flokli mentioned this pull request Mar 12, 2020
Merged
10 tasks
@flokli flokli requested a review from talyz March 12, 2020 02:09
@flokli flokli mentioned this pull request Mar 12, 2020
Merged
10 tasks
@flokli flokli added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 12, 2020
@flokli
Copy link
Contributor Author

flokli commented Mar 12, 2020

@GrahamcOfBorg test gitlab

@ofborg ofborg bot requested a review from ehmry March 12, 2020 02:11
@talyz
Copy link
Contributor

talyz commented Mar 12, 2020 •
edited

I haven't tried it yet, but it looks good. One thing I've noticed, however, is how the ugorji/go dep keeps flipping between v1.1.4 and d75b2dcb6bc8 every time we update, so I tried running the update script multiple times and it does indeed just flip back and forth between them even on the same version of gitaly. No idea why this happens, but maybe we should settle for the v1.1.4 version, since it's more recent and actually tagged? :)

@flokli
Copy link
Contributor Author

flokli commented Mar 12, 2020

@talyz Hah, I noticed the oscillating dependency now as well :-)

I regenerated again and pushed to this PR - will update the backport PRs in the next minute.

Should be good to merge then IMHO.

@talyz
Copy link
Contributor

talyz commented Mar 12, 2020

@flokli Great! Yeah, it's a small update and the tests pass, so we should be good :)

@flokli flokli merged commit 5459749 into NixOS:master Mar 12, 2020
@flokli flokli deleted the gitlab-12.8.6 branch March 12, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

@talyz talyz Awaiting requested review from talyz

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @talyz