More mypy, fix a couple of return types #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Mar 13, 2020
Co-Authored-By: Graham Christensen <graham@grahamc.com>
Co-Authored-By: Graham Christensen <graham@grahamc.com>
Co-Authored-By: Graham Christensen <graham@grahamc.com>
Co-Authored-By: Graham Christensen <graham@grahamc.com>
Co-Authored-By: Graham Christensen <graham@grahamc.com>
Co-Authored-By: Graham Christensen <graham@grahamc.com>
back out one silly None and narrow an Any to str
aaronchall
commented
Mar 13, 2020
|
Thank you a lot! |
|
Do my commits look good to you? |
|
looks great! I like the set annotation! |
grahamc
added a commit
that referenced
this pull request
Mar 13, 2020
More mypy, fix a couple of return types * back out one silly None and narrow an Any to str * str to Optional[str] for restore id arg type * black * backend: encrypted_links_to: prove that it is a set * backend: extract_key_options: type ET.Element Co-authored-by: Graham Christensen <graham@grahamc.com>
|
By the way, this is how this PR did: |
grahamc
added a commit
that referenced
this pull request
Mar 13, 2020
More mypy, fix a couple of return types * back out one silly None and narrow an Any to str * str to Optional[str] for restore id arg type * black * backend: encrypted_links_to: prove that it is a set * backend: extract_key_options: type ET.Element Co-authored-by: Graham Christensen <graham@grahamc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to edit further before merging if you like.