Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport-20.03] nixos/haproxy: Revive the haproxy user and group #82350

Merged
merged 1 commit into from Apr 2, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 11, 2020

Running haproxy with "DynamicUser = true" doesn't really work, since
it prohibits specifying a TLS certificate bundle with limited
permissions. This revives the haproxy user and group, but makes them
dynamically allocated by NixOS, rather than statically allocated. It
also adds options to specify which user and group haproxy runs as.

(cherry picked from commit bb7ad85)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Running haproxy with "DynamicUser = true" doesn't really work, since
it prohibits specifying a TLS certificate bundle with limited
permissions. This revives the haproxy user and group, but makes them
dynamically allocated by NixOS, rather than statically allocated. It
also adds options to specify which user and group haproxy runs as.

(cherry picked from commit bb7ad85)
@Mic92 Mic92 changed the title nixos/haproxy: Revive the haproxy user and group [backport-20.03] nixos/haproxy: Revive the haproxy user and group Mar 11, 2020
@Mic92
Copy link
Member Author

Mic92 commented Mar 11, 2020

backport of #82350

@talyz
Copy link
Contributor

talyz commented Mar 13, 2020

@GrahamcOfBorg test haproxy

@Mic92 Mic92 merged commit e3cf1bd into NixOS:release-20.03 Apr 2, 2020
@Mic92 Mic92 deleted the haproxy branch April 2, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants