Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: 1.41.0 -> 1.42.0 #82447

Merged
merged 1 commit into from Mar 13, 2020
Merged

rustc: 1.41.0 -> 1.42.0 #82447

merged 1 commit into from Mar 13, 2020

Conversation

alyssais
Copy link
Member

The patch is included in rust master1, but neither that, nor the
QuiltOS version we were using previously, apply to 1.42.0, so I've
included the fixed version here.

@GrahamcOfBorg build thunderbird firefox
@GrahamcOfBorg build fd

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
rustc: 1.41.0 -> 1.42.0
5741c2d 
The patch is included in rust master[1], but neither that, nor the
QuiltOS version we were using previously, apply to 1.42.0, so I've
included the fixed version here.

[1]: rust-lang/rust@4f15867
@alyssais
Copy link
Member Author

alyssais commented Mar 13, 2020 via email

@Mic92
Copy link
Member

Mic92 commented Mar 13, 2020 •
edited

I am going to have a look... https://github.com/kholia/OSX-KVM and the aarch64 builder as well

@Mic92
Copy link
Member

Mic92 commented Mar 13, 2020

The test on aarch64 only seems to fail sometimes? Weird.

@Mic92
Copy link
Member

Mic92 commented Mar 13, 2020

fd builds on aarch64-linux

@marsam
Copy link
Contributor

marsam commented Mar 13, 2020

I can confirm fd build on darwin

@alyssais alyssais merged commit dc3c338 into NixOS:staging Mar 13, 2020
@alyssais alyssais deleted the rust branch March 13, 2020 19:51
@Ericson2314
Copy link
Member

Ericson2314 commented Mar 13, 2020 •
edited

@alyssais thanks for back/forward porting!

@Ericson2314 Ericson2314 mentioned this pull request Mar 18, 2020
Closed
10 tasks
@oxalica oxalica mentioned this pull request Mar 28, 2020
Merged
10 tasks
bb010g added a commit to neXromancers/hacksaw that referenced this pull request May 2, 2020
@bb010g
Restore Rust 1.41.0 compatibility
e03afbf 
This allows building with default Rust on Nixpkgs channel `nixos-20.03`.
A `shell.nix` file has been added for easier future compatibility tests.

(Subslice patterns were introduced in 1.42; the Nixpkgs PR for Rust
1.41.0 -> 1.42.0 is NixOS/nixpkgs#82447 .)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblasc lblasc lblasc approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alyssais @Mic92 @marsam @Ericson2314 @lblasc