Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ratchet up mypy type coverage #1250

Merged
merged 3 commits into from Mar 12, 2020
Merged

Ratchet up mypy type coverage #1250

merged 3 commits into from Mar 12, 2020

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Mar 11, 2020 •
edited

This will require every PR to increase (or keep equal) total type coverage.

@grahamc grahamc force-pushed the travis-ci branch 3 times, most recently from b57a410 to 6a4f66f Compare March 12, 2020 01:43
@grahamc grahamc marked this pull request as ready for review March 12, 2020 01:49
@grahamc grahamc force-pushed the travis-ci branch 4 times, most recently from ca5c17e to f3cfb9d Compare March 12, 2020 02:15
@grahamc
Revert "have fewer types"
4532177 
This reverts commit cd13a9d.
@grahamc grahamc changed the title travis: experiment Ratchet up mypy type coverage Mar 12, 2020
lovesegfault
lovesegfault approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We may want to ci.nix -> ci/default.nix if we're going to have a dir for it

@grahamc grahamc merged commit b76dc58 into NixOS:master Mar 12, 2020
@grahamc grahamc deleted the travis-ci branch March 12, 2020 18:02
@grahamc grahamc added this to the 2.0 milestone Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grahamc @lovesegfault