Fix: [AI/GS] CanBuildConnectedRoadPartsHere neighbours tiles were at times incorrect #8036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
approved these changes
Mar 13, 2020
glx22
added
the
backport requested
|
It's not that hard to cache, same as other _map size variables. Just probably not worth it. |
SamuXarick
deleted the
CanBuildConnectedRoadPartsHere-incorrect-neighbours
branch
LordAro
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was very difficult to reproduce.
Seems to happen when the map size changes between a save and another. In the first map that has an AI calling this function for the first time, the neighbours diffs are calculated. The next calls, no longer recomputes the neighbour diffs. If I now load a save of a different map size, the neighbours are still of the previous map.
PS: I request backport, if that is still possible. My AI makes heavy use of this function with the pathfinder routine.