New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
octoprint: 1.3.12 -> 1.4.0, use python3 #82392
Conversation
Builds but not tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me.
Not building for me... what could I be doing wrong?
Metadata:
Relevant config: {
services.octoprint = {
enable = true;
plugins = plugins: with plugins; [
mqtt titlestatus stlviewer printtimegenius
abl-expert gcodeeditor simpleemergencystop
];
};
} |
I'm not using any plugins, so that's probably why I didn't run into your issue. It looks like the plugins are still using Python 2. |
I did try removing the plugins from my config. No change. With nothing but |
Indeed, Python 2 was still used for the plugins and thus the module. I've fixed this now, please review. I suggest reviewing the separate commits. |
Most of the plugins will need to be updated to their latest version for compatibility with 1.4.0. (Looking through a few, only |
I get an error when running
My octoprint configuration is as follows: services.octoprint = {
enable = true;
plugins = ps: with ps; [ printtimegenius touchui psucontrol ];
}; |
3e33205
to
b64d691
Compare
Should be fixed now.
That I leave up to the plugin maintainers. |
May I push the updates to your PR? |
Yes, please go ahead. |
@GrahamcOfBorg eval |
I rebased onto master. |
- ensure the plugins use the same python as octoprint - overlay of overriding plugins - drop octoprint-plugins attribute
Works for me as well. I've printed successfully. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theres some regressions in the cozy packages:
https://github.com/NixOS/nixpkgs/pull/82392
2 package failed to build:
python37Packages.cozy python38Packages.cozy
24 package built:
kodiPlugins.yatp octoprint python27Packages.celery python27Packages.flower python27Packages.kombu python27Packages.z3 python37Packages.celery python37Packages.django-raster python37Packages.djmail python37Packages.flower python37Packages.kombu python37Packages.z3 python37Packages.sentry-sdk python38Packages.z3 sourcehut.buildsrht sourcehut.dispatchsrht sourcehut.gitsrht sourcehut.hgsrht sourcehut.listssrht sourcehut.mansrht sourcehut.metasrht sourcehut.pastesrht sourcehut.todosrht tribler
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
EDIT: Er, looks like there's a conflict now. Never mind.
Hoping this can be resolved soonish. I'm in a bit of a pickle with regards to having to choose between a working printer or other working applications on master. |
I've merged master into this branch, and octoprint builds again. I've been waiting with merging this PR because of Ben's comment with |
I've reverted @FRidh's commit that adds For now, I've just set |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)