airwave: fix VST SDK and Qt plugins #82380
Conversation
* The currently required version (`vstsdk368_08_11_2017_build_121.zip`) seems to have fallen off the Internet. * The latest version (`vst-sdk_3.6.14_build-24_2019-11-29.zip`) can be automatically downloaded from Steinberg's servers, however it does not contain the VST2 SDK headers needed by Airwave. * I've raised an issue on the [Steinberg VST SDK GitHub](steinbergmedia/vst3sdk#51) to make the VST2 SDK easily available. * In the meantime, I propose this fix. It's the only way I've managed to build Airwave from nixpkgs; caveat, I am yet to test it with any real Windows VSTs.
* Replacing `multiStdenv.mkDerivation` with `qt5.makeDerivation` is not an option, making this one out of 2 derivations in nixpkgs to depend on `multiStdenv`. * However, adding `qt5.wrapQtAppsHook` to `nativeBuildInputs` is enough for the derivation to build; the resulting `airwave-manager` binary finds its runtime dependencies successfully. * Next: let's try bridging an actual plugin.
You can do |
| @@ -42,7 +41,7 @@ multiStdenv.mkDerivation { | |||
|
|
|||
| src = airwave-src; | |||
|
|
|||
| nativeBuildInputs = [ cmake makeWrapper ]; | |||
| nativeBuildInputs = [ cmake makeWrapper qt5.wrapQtAppsHook ]; | |||
|
|
|||
| buildInputs = [ file libX11 qt5.qtbase wine-xembed ]; | |||
There was a problem hiding this comment.
we should never reference qt5 directly, and instead should use the libsForQt5.callPackage function to bring all attributes within qt5 into scope.
There was a problem hiding this comment.
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity. Feel free to reopen the discussion. |
Motivation for this change
vstsdk368_08_11_2017_build_121.zip) has fallen off the Internet.vst-sdk_3.6.14_build-24_2019-11-29.zip) can be automatically downloaded from Steinberg's servers or from GitHub but does not contain the required VST2 SDK headers.Things done
vstsdk366_27_06_2016_build_61).qt5.wrapQtAppsHookinto nativeBuildInputs as per Tracking issue for wrapQtAppsHook #65399 (qt5.mkDerivationis not an option because ofmultiStdenv.mkDerivation- but hey, now it builds and runs!)sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)