Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/captive-browser: set chromium's data-dir to a XDG-compliant location #82339

Merged
merged 1 commit into from Apr 15, 2020
Merged

nixos/captive-browser: set chromium's data-dir to a XDG-compliant location #82339

merged 1 commit into from Apr 15, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 11, 2020

Motivation for this change

To quote the XDG specification:

 There is a single base directory relative to which user-specific
 data files should be written. This directory is defined by the\
 environment variable $XDG_DATA_HOME.

Rather than adding another directory to $HOME, I think that it's better
to follow this standard to avoid a cluttered home-dir.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
nixos/captive-browser: set chromium's data-dir to a XDG-compliant loc…
f073b74 
…ation

To quote the XDG specification:

     There is a single base directory relative to which user-specific
     data files should be written. This directory is defined by the\
     environment variable $XDG_DATA_HOME.

Rather than adding another directory to $HOME, I think that it's better
to follow this standard to avoid a cluttered home-dir.
@Ma27 Ma27 requested a review from volth March 11, 2020 20:03
@Ma27
Copy link
Member Author

Ma27 commented Apr 15, 2020

This PR has been open for a while now and is IMHO a valid improvement -> merging for now. Also I'm using this change for a few weeks now without any issues.

I'll keep your suggestions for improvements in mind, I actually have (pretty unstable) draft in my git-stash since I wanted to add support for networkd with udhcpc for captive-browser. Will probably file a PR for this during the next weeks :)

@Ma27 Ma27 merged commit 70ecf83 into NixOS:master Apr 15, 2020
@Ma27 Ma27 deleted the captive-browser-xdg branch April 15, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ma27