Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blender: use PYTHONPATH (#82337) #82341

Merged
merged 1 commit into from Mar 12, 2020
Merged

blender: use PYTHONPATH (#82337) #82341

merged 1 commit into from Mar 12, 2020

Conversation

amurrayc
Copy link
Contributor

@amurrayc amurrayc commented Mar 11, 2020 •
edited

See blender patch

Motivation for this change

Enable e.g. numpy-dependent add-ons to load. Blender stopped using PYTHONPATH by default.
Fixes #82337

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cillianderoiste March 11, 2020 20:34
@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 11, 2020
@amurrayc
Copy link
Contributor Author

I'm not sure what the correct procedure is for the port to stable but the PR seems to apply cleanly to release-20.03 at the moment.

@veprbl veprbl self-assigned this Mar 12, 2020
@veprbl veprbl merged commit fd614a7 into NixOS:master Mar 12, 2020
veprbl pushed a commit that referenced this pull request Mar 12, 2020
@amurrayc @veprbl
blender: use PYTHONPATH (#82341)
063c26c 
See [blender patch](https://developer.blender.org/D6598)

(cherry picked from commit fd614a7)
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 12, 2020
@veprbl
Copy link
Member

veprbl commented Mar 12, 2020

@amurrayc Thanks for fixing this and checking for release-20.03. I did the backport.

@veprbl veprbl removed their assignment Mar 12, 2020
@amurrayc amurrayc deleted the blender-2.82-pythonenv branch March 13, 2020 01:07
@ju1m ju1m mentioned this pull request Apr 10, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blender 2.82: python environment still not picked up by add-ons
3 participants
@amurrayc @veprbl @Janik-Haag