Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kvmgt: udev rules + fix module initialisation #82468

Merged
merged 2 commits into from Mar 14, 2020
Merged

nixos/kvmgt: udev rules + fix module initialisation #82468

merged 2 commits into from Mar 14, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 13, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
nixos/kvmgt: fix driver option
85aae79 
extraModprobeConfig could be applied too late i.e. if the driver has been
loaded in initrd, while the harddrive is still encrypted.
Using a kernelParams works in all cases however.
@Mic92
nixos/kvmgt: add udev rules for unprivileged access
505d241
@Mic92 Mic92 requested a review from a user March 13, 2020 07:05
ghost
ghost reviewed Mar 14, 2020
View reviewed changes
nixos/modules/virtualisation/kvmgt.nix
boot.extraModprobeConfig = ''
options i915 enable_gvt=1
'';
boot.kernelParams = [ "i915.enable_gvt=1" ];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also moved the kernel option to modprobe configuration - this is somewhat controversial, my reasoning is that options for modules should be there to avoid command line bloat and be a single source of truth.

@abbradar via #64425

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, missed your commit message about extraModprobeConfig

ghost
ghost approved these changes Mar 14, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mic92 Mic92 merged commit 4a8a014 into NixOS:master Mar 14, 2020
@Mic92 Mic92 deleted the kvmgt branch March 14, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92