Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navi: init 2.1.1 #82476

Closed
wants to merge 1 commit into from
Closed

navi: init 2.1.1 #82476

wants to merge 1 commit into from

Conversation

mrVanDalo
Copy link
Contributor

Motivation for this change

A nice cheat sheet tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/applications/misc/navi/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/navi/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/navi/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/navi/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/navi/default.nix Outdated Show resolved Hide resolved
@mrVanDalo
Copy link
Contributor Author

mrVanDalo commented Mar 14, 2020

@alyssais did your comments and bumped to version 2.0.11.

@mrVanDalo mrVanDalo changed the title navi: init 2.0.8 navi: init 2.0.11 Mar 14, 2020
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

pkgs/applications/misc/navi/default.nix Outdated Show resolved Hide resolved
@alyssais
Copy link
Member

@GrahamcOfBorg build navi

description = "An interactive cheatsheet tool for the command-line";
homepage = "https://github.com/denisidoro/navi";
license = licenses.asl20;
platforms = platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really linux only??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it works also on other systems, but I can't verify that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the README, it clearly supports at least Darwin. The best approach here is to use common sense, and err in the side of being over-broad, to prevent cases where somebody wants to use a package that would otherwise work, but they’re told they’re not allowed to.

So in this case I suggest platforms.unix.

@alyssais
Copy link
Member

You also need to add an attribute in all-packages.nix — this derivation isn’t reachable

@mrVanDalo
Copy link
Contributor Author

mrVanDalo commented Mar 15, 2020

You also need to add an attribute in all-packages.nix — this derivation isn’t reachable

ähhm, ... lol, ... how could I forget that :D
Thanks for the help.

@mrVanDalo
Copy link
Contributor Author

I also add the shell folder to $out. In there are not shell completion scripts. They are script so add a shortcut Ctrl-G to call navi which prints to the terminal so you can post edit it.

@alyssais
Copy link
Member

Build failed. I think verifyCargoDeps doesn’t exist any more on master, and the cargoSha256 might need to be recalculated.

@mrVanDalo mrVanDalo changed the title navi: init 2.0.11 navi: init 2.1.1 Mar 16, 2020
@mrVanDalo
Copy link
Contributor Author

Build failed. I think verifyCargoDeps doesn’t exist any more on master, and the cargoSha256 might need to be recalculated.

Yes, now it should work again. There is a newer version, 2.1.3 but I can't get that one to build. I will try next week again. But this one should work fine now.

@cust0dian-old cust0dian-old mentioned this pull request Aug 1, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants