New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navi: init 2.1.1 #82476
navi: init 2.1.1 #82476
Conversation
@alyssais did your comments and bumped to version 2.0.11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
@GrahamcOfBorg build navi |
description = "An interactive cheatsheet tool for the command-line"; | ||
homepage = "https://github.com/denisidoro/navi"; | ||
license = licenses.asl20; | ||
platforms = platforms.linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really linux only??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it works also on other systems, but I can't verify that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the README, it clearly supports at least Darwin. The best approach here is to use common sense, and err in the side of being over-broad, to prevent cases where somebody wants to use a package that would otherwise work, but they’re told they’re not allowed to.
So in this case I suggest platforms.unix.
You also need to add an attribute in all-packages.nix — this derivation isn’t reachable |
ähhm, ... lol, ... how could I forget that :D |
5237ffb
to
8a46d12
Compare
5a4a21b
to
8ea7d56
Compare
I also add the |
Build failed. I think verifyCargoDeps doesn’t exist any more on master, and the cargoSha256 might need to be recalculated. |
Yes, now it should work again. There is a newer version, 2.1.3 but I can't get that one to build. I will try next week again. But this one should work fine now. |
Motivation for this change
A nice cheat sheet tool.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)