New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscodeExtensions.ms-vscode-remote.remote-ssh: 0.48.0 -> 0.50.0 #82487
Conversation
@GrahamcOfBorg eval |
Unfortunately, this does not function for me, and I can see no obvious reason why. In VScode, extension is not listed under "Enabled," but if I search for it I do see an option to uninstall, so it's detected on some level. remote-ssh is not available as a command. I sadly don't have bandwidth to investigate right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
builds fine
[nix-shell:/home/jon/.cache/nixpkgs-review/pr-82487]$ nix-build ./nixpkgs/ -A vscode-extensions.ms-vscode-remote
these derivations will be built:
/nix/store/0amya2q2zsa5vqp70n6aq72nrwp5apmw-ms-vscode-remote-remote-ssh.zip.drv
/nix/store/9d7ph10a0alxafcwwzjikkjhkvbmc74w-vscode-extension-ms-vscode-remote-remote-ssh-0.50.0.drv
building '/nix/store/0amya2q2zsa5vqp70n6aq72nrwp5apmw-ms-vscode-remote-remote-ssh.zip.drv'...
trying https://ms-vscode-remote.gallery.vsassets.io/_apis/public/gallery/publisher/ms-vscode-remote/extension/remote-ssh/0.50.0/assetbyname/Microsoft.VisualStudio.Services.VSIXPackage
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 671k 100 671k 0 0 201k 0 0:00:03 0:00:03 --:--:-- 201k
building '/nix/store/9d7ph10a0alxafcwwzjikkjhkvbmc74w-vscode-extension-ms-vscode-remote-remote-ssh-0.50.0.drv'...
unpacking sources
unpacking source archive /nix/store/nc1z3z34avqwwyg31lky9q6pil70c8l8-ms-vscode-remote-remote-ssh.zip
source root is extension
setting SOURCE_DATE_EPOCH to timestamp 1583788674 of file extension/README.md
patching sources
configuring
building
installing
post-installation fixup
patching script interpreter paths in /nix/store/20acnnrq02kdfbzy0a17lvq8l96zm6g5-vscode-extension-ms-vscode-remote-remote-ssh-0.50.0
/nix/store/20acnnrq02kdfbzy0a17lvq8l96zm6g5-vscode-extension-ms-vscode-remote-remote-ssh-0.50.0/ms-vscode-remote.remote-ssh/out/utils/terminateProcess.sh: interpreter directive changed from "/bin/bash" to "/nix/store/z4ajipns0l1s8b2lrgpy6nng4cys7h99-bash-4.4-p23/bin/bash"
/nix/store/20acnnrq02kdfbzy0a17lvq8l96zm6g5-vscode-extension-ms-vscode-remote-remote-ssh-0.50.0/ms-vscode-remote.remote-ssh/out/local-server/askpass.sh: interpreter directive changed from "/bin/sh" to "/nix/store/z4ajipns0l1s8b2lrgpy6nng4cys7h99-bash-4.4-p23/bin/sh"
checking for references to /build/ in /nix/store/20acnnrq02kdfbzy0a17lvq8l96zm6g5-vscode-extension-ms-vscode-remote-remote-ssh-0.50.0...
/nix/store/20acnnrq02kdfbzy0a17lvq8l96zm6g5-vscode-extension-ms-vscode-remote-remote-ssh-0.50.0
@jonringer did you see my comment? Even though this builds, when I tested it was not functional. Unless someone can comment that they functionally tested that this works, can you please revert? |
looks like all vscode extensions are broken on master due to the a change in makeDesktopItem |
|
Actually I take that back, it seems 9665977 caused the regression |
Ah thanks for the excellent bisecting |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)