Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ngscopeclient/scopehal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9ad4c5e75616
Choose a base ref
...
head repository: ngscopeclient/scopehal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 370b89906574
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 13, 2020

  1. Oscilloscope: fixed memory leak of pending waveforms during deletion

    @azonenberg
    azonenberg committed Mar 13, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    370b899 View commit details
Showing with 7 additions and 0 deletions.
  1. +7 −0 scopehal/Oscilloscope.cpp
7 changes: 7 additions & 0 deletions scopehal/Oscilloscope.cpp
View file
Original file line number Diff line number Diff line change
@@ -59,6 +59,13 @@ Oscilloscope::~Oscilloscope()
for(size_t i=0; i<m_channels.size(); i++)
delete m_channels[i];
m_channels.clear();

for(auto set : m_pendingWaveforms)
{
for(auto it : set)
delete it.second;
}
m_pendingWaveforms.clear();
}

////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////