New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql-workbench: 8.0.15 → 8.0.19 #82362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR's changes to mysql-workbench
are nicely split into pure formatting / code style changes on one hand (934bb11) and semantic changes on the other (5b7f60a).
Can you similarly split up the changes to libmysqlconnectorcpp
which are currently all in a67a72d?
Seems to fail to build at the moment:
|
I only split the formatting changes when it would obscure the other changes. The libmysqlconnectorcpp change is so small I do not see a need for splitting it in two. |
This has been seriously outdated: * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-1-1-10.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-1-1-11.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-1-1-12.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-1-1-13.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-2-0-1.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-2-0-2.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-2-0-3.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-2-0-4.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-5.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-6.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-7.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-8-through-10.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-11.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-12.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-13.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-14.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-15.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-16.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-17.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-18.html * https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-19.html Expression changes: * Format with nixpkgs-fmt. * Move cmake to nativeBuildInputs. * Use OpenSSL from the system as using the bundled version is now optional. * Use MysQL 8.0 since this is supposed to be used with that version. * Explicitly enable the now legacy JDBC library used by mysql-workbench. * Remove unnecessary MYSQL_LIB_DIR flag. MySQL will be found automatically. * We just need the build script know it is not a static library.
c1fbc3f
to
d2751d5
Compare
* https://dev.mysql.com/doc/relnotes/workbench/en/news-8-0-16.html * https://dev.mysql.com/doc/relnotes/workbench/en/news-8-0-17.html * https://dev.mysql.com/doc/relnotes/workbench/en/news-8-0-18.html * https://dev.mysql.com/doc/relnotes/workbench/en/news-8-0-19.html The release notes contain the following: Important Note: MySQL Workbench 8.0.19 is unable to open a new connection to MySQL Server from the home screen if the server is not started and you cannot start a server by using the Workbench Administration feature. Administrative and SQL editing tasks require an online server for the duration of this issue. Feature tasks that you performed with an offline server in previous releases now return an error message indicating that the server is unreachable. but it is clearly better than having it broken.
@jtojnar looks like |
Backported:
|
Thanks 🎉 |
Motivation for this change
Closes: #78770
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)