Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade vscode extension versions for Scala #82440

Closed
wants to merge 2 commits into from

Conversation

Zhen-hao
Copy link

@Zhen-hao Zhen-hao commented Mar 12, 2020

Motivation for this change

to update the vscode extensions for Scala to their latest version. merging this to master is fine because vscode 1.43 is already in the master branch. The minimal vscode version to use these new versions is 1.42.

Things done
  • Built on platform(s)

since vscode 1.43 is already on the master branch, this change will work fine (1.42 is required).
…ala-upgrade

upgraded scala-lang.scala and scala-lang.scala
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

should be 2 commits, one for each extensions

@Zhen-hao
Copy link
Author

@jonringer thanks for your feedback. I will create new PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants