Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geonkick: init at 2.3.3 #82442

Merged
merged 2 commits into from Aug 17, 2020
Merged

geonkick: init at 2.3.3 #82442

merged 2 commits into from Aug 17, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Mar 12, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@magnetophon magnetophon force-pushed the geonkick branch 2 times, most recently from 4826a69 to fa2c6dc Compare March 26, 2020 06:17
@magnetophon magnetophon changed the title geonkick: init at 1.9.2 geonkick: init at 1.10.0 Apr 3, 2020
@magnetophon magnetophon changed the title geonkick: init at 1.10.0 geonkick: init at 2.0.0 Apr 18, 2020
@magnetophon
Copy link
Member Author

@mmahut Could you have another look please?

@magnetophon magnetophon changed the title geonkick: init at 2.0.0 geonkick: init at 2.0.1 Apr 20, 2020
@magnetophon magnetophon changed the title geonkick: init at 2.0.1 geonkick: init at 2.0.2 Apr 22, 2020
@magnetophon magnetophon mentioned this pull request Jun 5, 2020
Draft
10 tasks
@magnetophon magnetophon changed the title geonkick: init at 2.0.2 geonkick: init at 2.1.1 Jun 8, 2020
@magnetophon magnetophon changed the title geonkick: init at 2.1.1 geonkick: init at 2.2.0 Jun 11, 2020
@magnetophon
Copy link
Member Author

@mmahut @doronbehar @jtojnar Any comments on https://github.com/iurie-sw/geonkick/issues/87?

@magnetophon magnetophon force-pushed the geonkick branch 2 times, most recently from 86bcac3 to 1bb48fc Compare June 11, 2020 16:22
@magnetophon magnetophon changed the title geonkick: init at 2.2.0 geonkick: init at 2.2.1 Jun 11, 2020
@magnetophon
Copy link
Member Author

magnetophon commented Jun 11, 2020 •
edited

I don't understand the error grahamcofborg-eval is giving.
Can someone explain?

@jtojnar
Copy link
Contributor

jtojnar commented Jun 11, 2020 •
edited

Looks unrelated to this PR. Something in master is printing a warning when it is not supposed to.

@magnetophon
Copy link
Member Author

Thanks.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 11, 2020

This commit needs to be reverted: 7be315a

@jtojnar
Copy link
Contributor

jtojnar commented Jun 12, 2020

@GrahamcOfBorg eval

@magnetophon magnetophon changed the title geonkick: init at 2.2.1 geonkick: init at 2.2.2 Jun 12, 2020
@magnetophon magnetophon changed the title geonkick: init at 2.2.2 geonkick: init at 2.2.3 Jun 12, 2020
@magnetophon magnetophon force-pushed the geonkick branch 2 times, most recently from 8cd4ac3 to bb6c7f1 Compare June 12, 2020 13:55
@magnetophon magnetophon changed the title geonkick: init at 2.2.3 geonkick: init at 2.3.3 Aug 1, 2020
@orivej-nixos orivej-nixos merged commit f657042 into NixOS:master Aug 17, 2020
@magnetophon magnetophon deleted the geonkick branch August 17, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magnetophon @jtojnar @mmahut @orivej-nixos