Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.vtk: Fix build #82336

Merged
merged 1 commit into from Mar 13, 2020
Merged

python37Packages.vtk: Fix build #82336

merged 1 commit into from Mar 13, 2020

Conversation

knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Mar 11, 2020 •
edited by veprbl

Motivation for this change

This should fix the build of vtk.
#80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin
Copy link
Member

bcdarwin commented Mar 13, 2020 •
edited

Builds on Ubuntu with Python 3.7 and 3.8 (and nixpkgs-review succeeds). VTK seems to be broken separately on Darwin.

Needs backport to 20.03.

@veprbl veprbl merged commit de36c3b into NixOS:master Mar 13, 2020
veprbl pushed a commit that referenced this pull request Mar 14, 2020
@knedlsepp @veprbl
python37Packages.vtk: Fix build (#82336)
c2e347c 
(cherry picked from commit de36c3b)
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @bcdarwin @veprbl