pathInfoCache: Respect disk cache TTLs #3398 #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
reviewed
Mar 12, 2020
src/libstore/store-api.hh
Outdated
| // Past tense, because a path can only be assumed to exists when | ||
| // isKnownNow() && didExist() | ||
| inline bool didExist() { | ||
| return value != 0; |
src/libstore/store-api.hh
Outdated
|
|
||
| PathInfoCacheValue(std::shared_ptr<const ValidPathInfo> value) : | ||
| time_point(std::chrono::steady_clock::now()), | ||
| value(value) {} |
There was a problem hiding this comment.
Since we're using C++20 now, constructors for "trivial" data classes can be omitted using designated initializers, e.g.
PathInfoCacheValue { .value = some_value }
and time_point could have a default initializer:
std::chrono::time_point<std::chrono::steady_clock> time_point = std::chrono::steady_clock::now();
src/libstore/store-api.cc
Outdated
| throw InvalidPath("path '%s' is not valid", printStorePath(storePath)); | ||
| return callback(ref<const ValidPathInfo>(*res)); | ||
| callback(ref<const ValidPathInfo>(res->value)); |
There was a problem hiding this comment.
Hm, removing the return looks potentially wrong...
There was a problem hiding this comment.
Yes it was. The compiler was complaining about return in a void function. I've re-added the return and then it works.
roberth
force-pushed
the
issue-3398-path-info-cache-ttls
branch
from
7e6fdb9
to
22e5b50
Compare
roberth
force-pushed
the
issue-3398-path-info-cache-ttls
branch
from
22e5b50
to
3f55f8a
Compare
|
Ready for review. I'll make a PR with the previous variation for a 2.3 backport. |
roberth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.