Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php73: 7.3.14 -> 7.3.15, php72: 7.2.27 -> 7.2.28, php: php73 -> php74 #82338

Merged
merged 3 commits into from Mar 11, 2020
Merged

php73: 7.3.14 -> 7.3.15, php72: 7.2.27 -> 7.2.28, php: php73 -> php74 #82338

merged 3 commits into from Mar 11, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Mar 11, 2020 •
edited

Motivation for this change

Changelog: https://www.php.net/ChangeLog-7.php#7.2.28
Changelog: https://www.php.net/ChangeLog-7.php#7.3.14

This also changes so we default to php74.

The upgrade commits should be backported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu requested a review from aanderse March 11, 2020 19:24
@ofborg ofborg bot requested review from globin and Ma27 March 11, 2020 19:35
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 11, 2020
@Ma27 Ma27 merged commit eebe76f into NixOS:master Mar 11, 2020
@Ma27
Copy link
Member

Ma27 commented Mar 11, 2020

Thanks!

20.03: b53b0a0, b151391
19.09: ae21ac7, 0010886

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 11, 2020
@etu etu deleted the php-package-updates branch March 11, 2020 22:03
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 11, 2020
@Ma27 @dtzWill
Merge pull request NixOS#82338 from etu/php-package-updates
ba9f2d4 
 php73: 7.3.14 -> 7.3.15, php72: 7.2.27 -> 7.2.28, php: php73 -> php74

(cherry picked from commit eebe76f)
@mmilata mmilata mentioned this pull request Mar 12, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@aanderse aanderse Awaiting requested review from aanderse aanderse is a code owner

@globin globin Awaiting requested review from globin globin is a code owner

Assignees
No one assigned
Labels
1.severity: security 6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: package (new) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @Ma27