Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fenics: Fix and update #82356

Merged
merged 2 commits into from Mar 20, 2020
Merged

fenics: Fix and update #82356

merged 2 commits into from Mar 20, 2020

Conversation

knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Mar 11, 2020 •
edited

Motivation for this change

This PR:

It doesn't however:

I want to expand on the test once I can get the remaining backends working. I do however think the changes are already "good enough" to the extent that they warrant a merge.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Mar 12, 2020
View reviewed changes
pkgs/development/libraries/science/math/fenics/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/science/math/fenics/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/science/math/fenics/default.nix Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@knedlsepp
Copy link
Member Author

Thx for the review. Did apply your suggestions.

@wd15
Copy link
Contributor

wd15 commented Mar 20, 2020

Result of nixpkgs-review pr 82356 1

2 package built:
  • python37Packages.fenics
  • python38Packages.fenics

jonringer
jonringer approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[14 built, 2 copied (12.6 MiB), 1.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82356
2 package built:
python37Packages.fenics python38Packages.fenics

@jonringer jonringer merged commit bffc749 into NixOS:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fenics fails to install on current unstable as of Dec 18 2019
3 participants
@knedlsepp @wd15 @jonringer