Checks: '-*,modernize-use-emplace,modernize-use-default-member-init,modernize-use-equals-delete,modernize-use-equals-default,modernize-return-braced-init-list,modernize-loop-convert,modernize-avoid-bind,misc-throw-by-value-catch-by-reference,misc-string-compare,misc-inefficient-algorithm,misc-inaccurate-erase,misc-incorrect-roundings,misc-unconventional-assign-operator,bugprone-suspicious-memset-usage,performance-*'

- key: modernize-use-default-member-init.UseAssignment

value: True

files_to_analyze="$(find src/ -name '*.cpp' -or -name '*.h')"

./util/travis/run-clang-tidy.py -clang-tidy-binary=${CLANG_TIDY} -p cmakebuild \

-checks='-*,modernize-use-emplace,modernize-avoid-bind,performance-*' \

-warningsaserrors='-*,modernize-use-emplace,performance-type-promotion-in-math-fn,performance-faster-string-find,performance-implicit-cast-in-loop' \

-no-command-on-stdout -quiet \

import Queue

class TidyQueue(Queue.Queue):

def __init__(self, max_task):

Queue.Queue.__init__(self, max_task)

self.has_error = False

"""Adjusts the directory until a compilation database is found."""

result = './'

while not os.path.isfile(os.path.join(result, path)):

if os.path.realpath(result) == '/':

print('Error: could not find compilation database.')

sys.exit(1)

result += '../'

return os.path.realpath(result)

def get_tidy_invocation(f, clang_tidy_binary, checks, warningsaserrors,

tmpdir, build_path,

header_filter, extra_arg, extra_arg_before, quiet):

"""Gets a command line for clang-tidy."""

start = [clang_tidy_binary]

if header_filter is not None:

start.append('-header-filter=' + header_filter)

else:

# Show warnings in all in-project headers by default.

start.append('-header-filter=^' + build_path + '/.*')

if checks:

start.append('-checks=' + checks)

if warningsaserrors:

start.append('-warnings-as-errors=' + warningsaserrors)

if tmpdir is not None:

start.append('-export-fixes')

# Get a temporary file. We immediately close the handle so clang-tidy can

# overwrite it.

(handle, name) = tempfile.mkstemp(suffix='.yaml', dir=tmpdir)

os.close(handle)

start.append(name)

for arg in extra_arg:

start.append('-extra-arg=%s' % arg)

for arg in extra_arg_before:

start.append('-extra-arg-before=%s' % arg)

start.append('-p=' + build_path)

if quiet:

start.append('-quiet')

start.append(f)

return start

"""Checks if invoking supplied clang-apply-replacements binary works."""

try:

subprocess.check_call([args.clang_apply_replacements_binary, '--version'])

except:

print('Unable to run clang-apply-replacements. Is clang-apply-replacements '

'binary correctly specified?', file=sys.stderr)

traceback.print_exc()

sys.exit(1)

"""Calls clang-apply-fixes on a given directory. Deletes the dir when done."""

invocation = [args.clang_apply_replacements_binary]

if args.format:

invocation.append('-format')

if args.style:

invocation.append('-style=' + args.style)

invocation.append(tmpdir)

subprocess.call(invocation)

def run_tidy(args, tmpdir, build_path, queue):

"""Takes filenames out of queue and runs clang-tidy on them."""

while True:

name = queue.get()

invocation = get_tidy_invocation(name, args.clang_tidy_binary, args.checks,

args.warningsaserrors, tmpdir, build_path,

args.header_filter, args.extra_arg,

args.extra_arg_before, args.quiet)

if not args.no_command_on_stdout:

sys.stdout.write(' '.join(invocation) + '\n')

try:

subprocess.check_call(invocation)

except subprocess.CalledProcessError:

queue.has_error = True

queue.task_done()

parser = argparse.ArgumentParser(description='Runs clang-tidy over all files '

'in a compilation database. Requires '

'clang-tidy and clang-apply-replacements in '

'$PATH.')

parser.add_argument('-clang-tidy-binary', metavar='PATH',

default='clang-tidy',

help='path to clang-tidy binary')

parser.add_argument('-clang-apply-replacements-binary', metavar='PATH',

default='clang-apply-replacements',

help='path to clang-apply-replacements binary')

parser.add_argument('-checks', default=None,

help='checks filter, when not specified, use clang-tidy '

'default')

parser.add_argument('-warningsaserrors', default=None,

help='warnings-as-errors filter, when not specified, '

'use clang-tidy default')

parser.add_argument('-header-filter', default=None,

help='regular expression matching the names of the '

'headers to output diagnostics from. Diagnostics from '

'the main file of each translation unit are always '

'displayed.')

parser.add_argument('-j', type=int, default=0,

help='number of tidy instances to be run in parallel.')

parser.add_argument('files', nargs='*', default=['.*'],

help='files to be processed (regex on path)')

parser.add_argument('-fix', action='store_true', help='apply fix-its')

parser.add_argument('-format', action='store_true', help='Reformat code '

'after applying fixes')

parser.add_argument('-style', default='file', help='The style of reformat '

'code after applying fixes')

parser.add_argument('-p', dest='build_path',

help='Path used to read a compile command database.')

parser.add_argument('-extra-arg', dest='extra_arg',

action='append', default=[],

help='Additional argument to append to the compiler '

'command line.')

parser.add_argument('-extra-arg-before', dest='extra_arg_before',

action='append', default=[],

help='Additional argument to prepend to the compiler '

'command line.')

parser.add_argument('-quiet', action='store_true',

help='Run clang-tidy in quiet mode')

parser.add_argument('-no-command-on-stdout', action='store_true',

help='Run clang-tidy without printing invocation on '

'stdout')

args = parser.parse_args()

db_path = 'compile_commands.json'

if args.build_path is not None:

build_path = args.build_path

# Find our database

build_path = find_compilation_database(db_path)

invocation = [args.clang_tidy_binary, '-list-checks', '-p=' + build_path]

if args.checks:

invocation.append('-checks=' + args.checks)

if args.warningsaserrors:

invocation.append('-warnings-as-errors=' + args.warningsaserrors)

invocation.append('-')

print(subprocess.check_output(invocation))

print("Unable to run clang-tidy.", file=sys.stderr)

sys.exit(1)

# Load the database and extract all files.

database = json.load(open(os.path.join(build_path, db_path)))

files = [entry['file'] for entry in database]

max_task = args.j

if max_task == 0:

max_task = multiprocessing.cpu_count()

tmpdir = None

if args.fix:

check_clang_apply_replacements_binary(args)

tmpdir = tempfile.mkdtemp()

# Build up a big regexy filter from all command line arguments.

file_name_re = re.compile('|'.join(args.files))

# Spin up a bunch of tidy-launching threads.

queue = TidyQueue(max_task)

for _ in range(max_task):

t = threading.Thread(target=run_tidy,

args=(args, tmpdir, build_path, queue))

t.daemon = True

t.start()

# Fill the queue with files.

for name in files:

if file_name_re.search(name):

queue.put(name)

# Wait for all threads to be done.

queue.join()

# If one clang-tidy process found and error, exit with non-zero

# status

if queue.has_error:

sys.exit(2)

except KeyboardInterrupt:

# This is a sad hack. Unfortunately subprocess goes

# bonkers with ctrl-c and we start forking merrily.

print('\nCtrl-C detected, goodbye.')

if args.fix:

shutil.rmtree(tmpdir)

os.kill(0, 9)

if args.fix:

print('Applying fixes ...')

successfully_applied = False

try:

apply_fixes(args, tmpdir)

successfully_applied = True

except:

print('Error applying fixes.\n', file=sys.stderr)

traceback.print_exc()

shutil.rmtree(tmpdir)

if not successfully_applied:

sys.exit(1)

main()