Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.httplib2: 0.15 -> 0.17 #82355

Merged
merged 1 commit into from Mar 21, 2020
Merged

python3Packages.httplib2: 0.15 -> 0.17 #82355

merged 1 commit into from Mar 21, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Mar 11, 2020 •
edited

Motivation for this change

Required for python3Packages.google_api_python_client: 1.7.11 -> 1.7.12.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

this does seem to cause a regression in python3Packages.celery

@FRidh FRidh added this to WIP in Staging via automation Mar 12, 2020
@primeos
Copy link
Member Author

primeos commented Mar 12, 2020

@jonringer are you sure that is due to the httplib2 update? The build already failed on Hydra and my nix-review output looks pretty identical:

builder for '/nix/store/hi36j9xv7q0zwyj66lyiqlx8vs4g5935-python3.8-celery-4.4.0.drv' failed with exit code 1; last 10 log lines:

    Traceback (most recent call last):
      File "/nix/store/846fz80fiz97cjyyqzq6zgmsamaahrvx-python3.8-celery-4.4.0/lib/python3.8/site-packages/celery/app/trace.py", line 362, in trace_task
        raise InvalidTaskError(
    celery.exceptions.InvalidTaskError: Task keyword arguments is not a mapping

      warn(RuntimeWarning(

  -- Docs: https://docs.pytest.org/en/latest/warnings.html
  = 2403 passed, 145 skipped, 2 deselected, 40 warnings, 1 error in 99.12s (0:01:39) =

My nix-review process is still running:

[2/367/383 built (48 failed), 2836 copied (16488.0/16499.3 MiB), 4414.5 MiB DL] building python3.7-pytorch-1.2.0 (buildPhase): [1424/2994] Building NVCC (Device) object caffe2/CMakeFiles/torch.dir/__/aten/src/AT

But once it's finished I can also post the output. Currently the build failures seem to be unrelated (though there are way more than expected :o). I'm not sure about the behaviour at run-time but I did quickly test this update on my system via GooBook, Ansible, and NixOps.

Also: Should I switch the target branch to staging?

@primeos primeos changed the base branch from master to staging March 15, 2020 10:45
@primeos
Copy link
Member Author

primeos commented Mar 15, 2020

Rebased on staging.
This is the nix-review output: https://gist.github.com/primeos/9ad1bf60b3b87e6917cc68d949922b87
There are a lot of failures, but I didn't see anything that seemed related to httplib2.

If there are no objections I'd like to merge this.

primeos added a commit that referenced this pull request Mar 15, 2020
@primeos
python3Packages.google_api_python_client: 1.7.12 -> 1.8.0
7a1c9d8 
This version doesn't depend on
#82355 anymore.
@primeos primeos merged commit b67aafe into NixOS:staging Mar 21, 2020
Staging automation moved this from WIP to Done Mar 21, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jul 6, 2020
@primeos @dtzWill
python3Packages.google_api_python_client: 1.7.12 -> 1.8.0
ab25e1d 
This version doesn't depend on
NixOS#82355 anymore.

(cherry picked from commit 7a1c9d8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @jonringer