include nix install script in the website and remove the redirect (fo… #335
Conversation
…r now) also: - use GITHUB_TOKEN instead of custom GH_TOKEN - don't create comment on cron jobs
|
For those out of the loop, and history spelunkers, can the reason for keeping the script as a website artifact, rather than a redirect, be added to either a comment to the Netlify config, or described in the PR body? I'm saying this since I don't know, and I've been kinda following what's going on. |
| @@ -0,0 +1,27 @@ | |||
| name: "Hourly Build & Deploy to Netlify" | |||
There was a problem hiding this comment.
What the difference between this and .github/workflows/main.yml (which also has a cron: '0 * * * *' line)?
There was a problem hiding this comment.
oh sorry, i was suppose to remove cron from main.yml. i'll fix it.
There was a problem hiding this comment.
I mean what's the difference? They look very similar. Do we need both?
There was a problem hiding this comment.
in cron.yml I also remove github-token to not add comments every hour. it makes listening to notifications on this github repo almost useless. this is the main reason for the split.
|
We probably also need to serve |
|
@samueldr The reason is that a lot of people are doing |
|
BTW breaking |
|
@edolstra i will create the redirects. but going forward people should rely on |
|
oh actually ... above should also just follow the redirect. |
…r now)
also: