Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fzf: 0.20.0 -> 0.21.0-1 #82474

Closed
wants to merge 1 commit into from
Closed

fzf: 0.20.0 -> 0.21.0-1 #82474

wants to merge 1 commit into from

Conversation

expipiplus1
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

This is a duplicate of #82454, right? I’m confused why GitHub will even let me merge it…

@alyssais alyssais closed this Mar 13, 2020
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Mar 14, 2020 •
edited

oops!

@alyssais I think the reason you're allowed to merge it is because this also updates the modSha256.

@zowoq, was not updating the go dependency has deliberate? It seems sensible to keep nixpkgs building fzf with the same dependencies as specified in the fzf repository.

edit: double oops

@zowoq
Copy link
Contributor

zowoq commented Mar 14, 2020 •
edited

modSha256 was updated for 0.21.0 in da13cdb

@expipiplus1
Copy link
Contributor Author

Ah yes, thanks @zowoq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: duplicate 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@expipiplus1 @alyssais @zowoq