Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim-plugins.coc-fzf: init at 2020-03-06 #82473

Merged
merged 1 commit into from Mar 27, 2020
Merged

vim-plugins.coc-fzf: init at 2020-03-06 #82473

merged 1 commit into from Mar 27, 2020

Conversation

expipiplus1
Copy link
Contributor

Tested working with the current version of coc.nvim and fzf

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Mar 14, 2020

amend the message to mention coc-fzf instead please

@expipiplus1
vim-plugins.coc-fzf: init at 2020-03-06
0d2a7f8 
Tested working with the current version of coc.nvim and fzf
@expipiplus1 expipiplus1 changed the title vim-plugins.coc-nvim: init at 2020-03-06 vim-plugins.coc-fzf: init at 2020-03-06 Mar 14, 2020
@expipiplus1
Copy link
Contributor Author

Done, good spot @teto.

jonringer
jonringer approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82473
1 package built:
vimPlugins.coc-fzf

@jonringer jonringer merged commit 7dd3d62 into NixOS:master Mar 27, 2020
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Mar 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@expipiplus1 @teto @jonringer