Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport 20.03] flexget: readd transmissionrpc #82403

Merged
merged 1 commit into from Mar 12, 2020
Merged

[backport 20.03] flexget: readd transmissionrpc #82403

merged 1 commit into from Mar 12, 2020

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented Mar 12, 2020

Motivation for this change

Backport of #82328 , @marsam

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eyJhb eyJhb force-pushed the flexget-transmission-release2003 branch 2 times, most recently from 3fc989a to 81b9b0c Compare March 12, 2020 12:29
@eyJhb eyJhb closed this Mar 12, 2020
@eyJhb eyJhb force-pushed the flexget-transmission-release2003 branch from 81b9b0c to dbacfa1 Compare March 12, 2020 12:31
@eyJhb eyJhb reopened this Mar 12, 2020
@eyJhb
Copy link
Member Author

eyJhb commented Mar 12, 2020

Should be good to go now. The unexpected reviewers, feel free to merge it! :)

@FRidh
Copy link
Member

FRidh commented Mar 12, 2020

please use cherry-pick -x when backporting

@eyJhb
flexget: readd transmissionrpc
71a0ae4 
(cherry picked from commit f88cd71)
@eyJhb eyJhb force-pushed the flexget-transmission-release2003 branch from 9c75c6b to 71a0ae4 Compare March 12, 2020 12:58
@eyJhb
Copy link
Member Author

eyJhb commented Mar 12, 2020

@FRidh done, sorry! :)

@eyJhb eyJhb changed the base branch from nixos-20.03 to release-20.03 March 12, 2020 12:59
@eyJhb
Copy link
Member Author

eyJhb commented Mar 12, 2020

Changed base to release-20.03 according to @adisbladis :)

@ofborg ofborg bot requested a review from marsam March 12, 2020 13:08
@adisbladis adisbladis merged commit 3bf5bf6 into NixOS:release-20.03 Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eyJhb @FRidh @adisbladis