Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] openjpeg: patch CVE-2020-6851 and CVE-2020-8112 #82445

Merged
merged 2 commits into from Mar 14, 2020
Merged

[19.09] openjpeg: patch CVE-2020-6851 and CVE-2020-8112 #82445

merged 2 commits into from Mar 14, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Mar 12, 2020

Backport of #82426. cc @veprbl

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
Copy link
Member

KamilaBorowska commented Mar 12, 2020 •
edited

Worth noting that this wasn't submitted to staging, but that may be fine, the vulnerability looks quite serious to me.

@mmilata
Copy link
Member Author

mmilata commented Mar 12, 2020

@xfix yeah, sorry, not sure what is the number of rebuilds where targeting staging makes sense

@KamilaBorowska
Copy link
Member

KamilaBorowska commented Mar 12, 2020 •
edited

This is more of a note to whoever merges this. Optimistically, I want to say this is a 2 hours rebuild, which is fine (and possible RCE is JPEG library sounds pretty bad at that), but somebody may disagree.

@alyssais alyssais merged commit 3b9b10e into NixOS:release-19.09 Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamilaBorowska KamilaBorowska KamilaBorowska approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmilata @KamilaBorowska @veprbl @alyssais