rtl-sdr: fix cross compilation #82412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornfor
requested changes
Mar 12, 2020
This patch partially fixes NixOS#81985. Cross-compiling rtl-sdr is possible using this patch. Use nix build -f <nixpkgs-path> -A pkgsCross.raspberryPi.rtl-sdr to build rtl-sdr. The error that occured when trying to do this before was as follows: /nix/store/ldb2v2z0198abkp2minr9a9vz5np4mn4-cmake-3.16.4-armv6l-unknown-linux-gnueabihf/nix-support/setup-hook: line 107: cmake: command not found
Mindavi
force-pushed
the
feature/rtl-sdr-cross-compilation
branch
from
8674b89
to
379e3d5
Compare
|
I've moved it, thanks for the quick review. |
bjornfor
approved these changes
Mar 13, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch partially fixes #81985.
Cross-compiling rtl-sdr is possible using this patch.
Use nix build -f -A pkgsCross.raspberryPi.rtl-sdr to build rtl-sdr.
The error that occured when trying to do this before was as follows:
/nix/store/ldb2v2z0198abkp2minr9a9vz5np4mn4-cmake-3.16.4-armv6l-unknown-linux-gnueabihf/nix-support/setup-hook: line 107: cmake: command not foundMotivation for this change
I want to be able to cross-compile rtl_433 using NixOS. This is a first step towards that goal.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /nix/store/b996ssrajnrjkni0fz3k7ihrp0m77ahr-glibc-2.30-armv6l-unknown-linux-gnueabihf/lib/ld-linux-armhf.so.3, for GNU/Linux 2.6.32, not stripped)nix path-info -Sbefore and after)Should this be merged to master or to another branch? I can't tell what's expected here.