Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifiStable: 5.12.35 -> 5.12.66 #83872

Merged
merged 1 commit into from Apr 15, 2020
Merged

unifiStable: 5.12.35 -> 5.12.66 #83872

merged 1 commit into from Apr 15, 2020

Conversation

bachp
Copy link
Member

@bachp bachp commented Mar 31, 2020

Motivation for this change

Update to latest version.

Things done

Running on my controller since yesterday.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from erictapen and globin April 1, 2020 00:47
erictapen
erictapen approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested the same a few days ago, but had some other problems in my setup. Which mongodb version from which branch are you running?

@bachp
Copy link
Member Author

bachp commented Apr 1, 2020 •
edited

I'm using mongodb from #40082

@bachp
Copy link
Member Author

bachp commented Apr 12, 2020

@globin please take a look

@globin
Copy link
Member

globin commented Apr 13, 2020

cc @elseym who wanted to test this tomorrow anyway

elseym
elseym approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@elseym elseym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine. thanks and sorry for the delay 😄

@elseym elseym merged commit 55e3272 into NixOS:master Apr 15, 2020
@bachp bachp deleted the unifi-5.12.66 branch April 15, 2020 19:50
@elseym
Copy link
Member

elseym commented Apr 16, 2020

backported to release-20.03 as 900b58e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elseym elseym elseym approved these changes

@erictapen erictapen erictapen approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bachp @globin @elseym @erictapen