Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retroarch/cores.nix: use correct platform for darwin #83891

Merged
merged 1 commit into from Apr 1, 2020
Merged

retroarch/cores.nix: use correct platform for darwin #83891

merged 1 commit into from Apr 1, 2020

Conversation

matthewbauer
Copy link
Member

This should fix the regression found in
https://hydra.nixos.org/eval/1577308#tabs-now-fail. The libretro
scripts use “osx” as the identifier for macOS, and “unix” seems to
mean linux.

If anyone could help out by confirming this works. I don’t currently
have access to a macOS machine.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
retroarch/cores.nix: use correct platform for darwin
eb84499 
This should fix the regression found in
https://hydra.nixos.org/eval/1577308#tabs-now-fail. The libretro
scripts use “osx” as the identifier for macOS, and “unix” seems to
mean linux.

If anyone could help out by confirming this works. I don’t currently
have access to a macOS machine.
@matthewbauer matthewbauer requested a review from LnL7 March 31, 2020 19:12
@matthewbauer
Copy link
Member Author

@GrahamcOfBorg build libretro

@matthewbauer
Copy link
Member Author

@GrahamcOfBorg build libretro.yabause libretro.stella

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 1, 2020
@ofborg ofborg bot requested review from edwtjo, MP2E and hrdinka April 1, 2020 02:36
@matthewbauer matthewbauer merged commit 8e3c712 into NixOS:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@edwtjo edwtjo Awaiting requested review from edwtjo

@MP2E MP2E Awaiting requested review from MP2E

@hrdinka hrdinka Awaiting requested review from hrdinka

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@matthewbauer