Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.picos: 1.2.0 -> 2.0 #83887

Merged

Conversation

tobiasBora
Copy link
Contributor

@tobiasBora tobiasBora commented Mar 31, 2020

Motivation for this change

Update of picos, the automatic PR 81971 was failing due to a missing dependency for the tests.

closes #81971

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

jonringer commented Mar 31, 2020

if you include closes or fixes and a PR number, github will automatically close that for you

@tobiasBora
Copy link
Contributor Author

tobiasBora commented Mar 31, 2020 via email

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 83887 1

3 packages built: - python27Packages.picos - python37Packages.picos - python38Packages.picos

@jonringer jonringer merged commit abe5f70 into NixOS:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants