Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.ibis: 1.2.0 -> 1.3.0, fix tests #83827

Merged
merged 1 commit into from Apr 16, 2020
Merged

python3Packages.ibis: 1.2.0 -> 1.3.0, fix tests #83827

merged 1 commit into from Apr 16, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 31, 2020 •
edited

Motivation for this change

noticed it was broken and causing a lot of issues when reviewing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/83827
32 package marked as broken and skipped:
digitalbitbox gdata-sharp glibcCross linuxPackages_4_4.evdi linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.prl-tools nix-linter php72Packages-unit.php_excel php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.php_excel php72Packages.v8 php72Packages.v8js php73Packages-unit.php_excel php73Packages-unit.v8 php73Packages.php_excel php73Packages.v8 php74Packages-unit.couchbase php74Packages-unit.pcs php74Packages-unit.php_excel php74Packages-unit.v8 php74Packages.couchbase php74Packages.pcs php74Packages.php_excel php74Packages.v8 python27Packages.flitBuildHook python37Packages.pyblock

1 package built:
python37Packages.ibis-framework

@jonringer jonringer requested a review from FRidh as a code owner March 31, 2020 02:48
@ofborg ofborg bot requested a review from costrouc March 31, 2020 03:19
@jonringer jonringer merged commit 0eec285 into NixOS:master Apr 16, 2020
@jonringer jonringer deleted the fix-ibis branch July 8, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer