Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk-gnutella: 1.1.14 -> 1.1.15 #83067

Merged
merged 1 commit into from Mar 31, 2020
Merged

gtk-gnutella: 1.1.14 -> 1.1.15 #83067

merged 1 commit into from Mar 31, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Mar 21, 2020 •
edited

Motivation for this change

Update gnutella and fix something in our build, see discussion with upstream: https://sourceforge.net/p/gtk-gnutella/bugs/555/ .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bhipple
bhipple requested changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash up all the commits? Otherwise LGTM.

@doronbehar
Copy link
Contributor Author

doronbehar commented Mar 30, 2020 via email

@doronbehar
gtk-gnutella: 1.1.14 -> 1.1.15
98f5d05 
Remove patches applied between 1.1.14 and 1.1.15 and switch to GitHub
source.
gtk-gnutella: several changes.
Disable internal malloc implementation.
Add @doronbehar as maintainer.
Comment about hardeningDisable regarding next release.
Format arguments and inputs.
Enable to disable GUI.
timokau
timokau approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Happy to see an orphaned package has found a new home.

@timokau timokau merged commit d277442 into NixOS:master Mar 31, 2020
@doronbehar doronbehar deleted the update-gtk-gnutella branch March 2, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@bhipple bhipple bhipple requested changes

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doronbehar @Mic92 @bhipple @timokau