Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zplug: init at 2.4.2 #83856

Closed
wants to merge 2 commits into from
Closed

zplug: init at 2.4.2 #83856

wants to merge 2 commits into from

Conversation

s1341
Copy link
Contributor

@s1341 s1341 commented Mar 31, 2020

Motivation for this change

Add the zplug zsh plugin manager.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@s1341
Copy link
Contributor Author

s1341 commented Mar 31, 2020

Note that my maintainer entry is in PR #82949

@s1341 s1341 mentioned this pull request Mar 31, 2020
Closed
@s1341
Copy link
Contributor Author

s1341 commented Apr 1, 2020

@GrahamcOfBorg eval

@rycee
Copy link
Member

rycee commented Apr 9, 2020

Thanks! Rebased to master in 71a768a.

@rycee rycee closed this Apr 9, 2020
@s1341
Copy link
Contributor Author

s1341 commented Apr 12, 2020

thanks @rycee!

@s1341 s1341 deleted the init_zplug branch April 12, 2020 07:21
@kayhide kayhide mentioned this pull request Jun 4, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s1341 @rycee