Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: 3.16.5 -> 3.17.0 #83862

Merged
merged 1 commit into from Apr 2, 2020
Merged

cmake: 3.16.5 -> 3.17.0 #83862

merged 1 commit into from Apr 2, 2020

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Mar 31, 2020 •
edited

Motivation for this change

Update the cmake library.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

How do we go about testing this one? it would update 12750 packages

cc @ttuegel @LnL7

@ttuegel
Copy link
Member

ttuegel commented Mar 31, 2020

How do we go about testing this one?

Please rebase the pull request onto the staging branch. We will test some canary packages by hand, and let Hydra test the rest after merging. The staging branch won't be merged into master until any significant problems are fixed.

@dasj19 dasj19 changed the base branch from master to staging March 31, 2020 16:57
@dasj19
Copy link
Contributor Author

dasj19 commented Mar 31, 2020 •
edited

@ttuegel I tryed rebasing using the CLI ... I did not succeed ... so I used the github button. Is it ok that changes from master come back into staging?

Edit: Never done a rebase.

@ofborg ofborg bot requested review from LnL7 and ttuegel April 1, 2020 00:18
@ttuegel
Copy link
Member

ttuegel commented Apr 1, 2020

Is it ok that changes from master come back into staging?

No, that's not OK, it needs to be done in a controlled way, and only when the staging-next branch is made.

@ttuegel
Copy link
Member

ttuegel commented Apr 1, 2020

I fixed up the rebase, I apologize for needing to force-push.

@ttuegel ttuegel merged commit 40239ac into NixOS:staging Apr 2, 2020
dasj19 referenced this pull request May 10, 2020
@r-ryantm @FRidh
cmake: 3.17.0 -> 3.17.2
27752d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasj19 @ttuegel