raylib: Init at 2.6.0 #83861
raylib: Init at 2.6.0 #83861
Conversation
svantepolk will maintain the raylib package.
| license = stdenv.lib.licenses.zlib; | ||
| maintainers = [ stdenv.lib.mantainers.svantepolk ]; | ||
| rev = version; | ||
| sha256 = hash; |
There was a problem hiding this comment.
I'm not familiar with some of these meta-attributes. Am I missing something?
There was a problem hiding this comment.
Mistakenly merged from a prior git source configuration I was trying. I've addressed this in a fixup.
| stdenv.mkDerivation { | ||
| inherit name; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
And usually meta is put at the end.
| name = "raylib-${version}"; | ||
| hash = "494e95eaf8daf3f086116dfd6a5fd2e9a2166fc744eabf4f3067bf887d4fb5ef"; | ||
| in | ||
| stdenv.mkDerivation { |
There was a problem hiding this comment.
Using let .. in is not necessary here - just put all of these variables inside mkDerivation. Also, switch to pname and put the hash in src = {.
| sha256 = hash; | ||
| }; | ||
|
|
||
| src = fetchurl { |
| @@ -0,0 +1,30 @@ | |||
| with import <nixpkgs> { }; | |||
There was a problem hiding this comment.
@svantepolk Could you please use:
| with import <nixpkgs> { }; | |
| { stdenv | |
| , fetchFromGitHub | |
| , libGl | |
| , xorg | |
| , xlibs | |
| , cmake | |
| }: |
Also, note the usage of fetchFromGitHub.
| pname = "raylib"; | ||
| version = "2.6.0"; | ||
|
|
||
| src = fetchurl { |
|
Also, please put everything you do in a single commit with message |
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
I didn't realise this PR existed when I created mine (#98029). |
stale
bot
removed
the
2.status: stale
doronbehar
added
the
2.status: stale
|
Thanks for that, @adamlwgriffiths |
Motivation for this change
I like raylib and would like it to be more accessible (since that's kind of the point of raylib).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)