Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce poetry(2nix), GitHub Actions, blackify all the files #9

Closed
wants to merge 11 commits into from

Conversation

andir
Copy link
Member

@andir andir commented Mar 31, 2020

Initially I wanted to hack on proper IPv6 support for NixOps on Hetzner. @grahamc convinced me to look into poetry and poetry2nix for this project. I fell for that trap.

Things done:

  • use poetry for dependency managemetn
  • introduce poetry2nix for packaging with Nix
  • ensure tests are still running (all 0 tests that I found with nose tests still work…)
  • add some simple CI to catch obvious Nix packaging, formatting & test errors (hah!)
  • updates development instructions

Future work:

  • remove the overlay.nix once poetry2nix is up2date in the nixpkgs-unstable channel
  • add type annotations and verify the using mypy (in CI)
  • add some integration tests with hetzner credentials (cc @grahamc)
  • do the actual tasks I wanted to do :D

@andir andir force-pushed the poetry2nix branch 3 times, most recently from 0d06917 to c681c30 Compare March 31, 2020 22:35
@andir
Copy link
Member Author

andir commented Mar 31, 2020

For the CI results you can have a look at my fork: https://github.com/andir/nixops-hetzner/actions/runs/67772822

@RoGryza
Copy link

RoGryza commented Sep 23, 2020

What's the status on this PR? Is it waiting for a NixOps release with the new plugin format?
I want to hack on the Hetzner plugin but I'm using NixOps on the master branch.
EDIT: It seems the NixOps branch referenced in pyproject.toml no longer exists

@andir
Copy link
Member Author

andir commented Sep 28, 2020 via email

@RoGryza
Copy link

RoGryza commented Sep 29, 2020

@andir I ended up starting a separate plugin for Hetzner Cloud integration here using the new NixOps plugin API, to be honest I'm not that inclined to put in the work on this conversion since I don't use Hetzner Robot

@tewfik-ghariani
Copy link
Contributor

This PR is superseded by #45

@andir andir closed this Jun 8, 2021
@andir andir deleted the poetry2nix branch June 8, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants