New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce poetry(2nix), GitHub Actions, blackify all the files #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andir
force-pushed
the
poetry2nix
branch
3 times, most recently
from
March 31, 2020 22:35
0d06917
to
c681c30
Compare
For the CI results you can have a look at my fork: https://github.com/andir/nixops-hetzner/actions/runs/67772822 |
> $ python tests.py > > ---------------------------------------------------------------------- > Ran 0 tests in 0.025s > > OK
16 tasks
What's the status on this PR? Is it waiting for a NixOps release with the new plugin format? |
On 06:17 23.09.20, Rodrigo Candido Gryzinski wrote:
What's the status on this PR? Is it waiting for a NixOps release with the new plugin format?
I want to hack on the Hetzner plugin but I'm using NixOps on the master branch
I only hacked this as initial draft to see how feasible a plugin
conversion is. I am not sure if we have a maintainer for this at all
that would even merge this without personally requiring this...
If you want to continue this please feel free to create another PR based
on this or lobby for getting it merged :)
|
This PR is superseded by #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I wanted to hack on proper IPv6 support for NixOps on Hetzner. @grahamc convinced me to look into poetry and poetry2nix for this project. I fell for that trap.
Things done:
Future work: