-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "nixos: default environment.homeBinInPath
to false"
#83881
Conversation
This reverts commit a06529b. Having ~/bin in $PATH has been the case in NixOS since forever or so, so I don't see a strong reason for changing this. People who don't want this can set environment.homeBinInPath to false now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would still like @andir opinion
I would argue that the more common case is to NOT have it on your path and if you need that you can opt-in to it. We have a proper release note entry documenting it. If we revert this how can we ever deprecate something? |
I don't really see the point of this option being in NixOS. It's something that can be done trivially in the user |
We've had this discussion before and the result was not to remove it (#40065). IMHO nothing has really changed since then. |
-1 on this Encouraging impurities like that should be kept to a minimum by default |
Looking at the old discussion we did lack a proper way of dealing with deprecation. I think we do have one and that is called release notes and a way to revert to the old (potentially never desired behavior). The change is listed in the category for breaking changes and has an almost copy-able line that enables the old mode of operation. ( We have had two users (you and @xeji) of use this. I am not sure if @xeji was aware of the feature since he stated it comes from his dotfiles repo anyway. The majority of people reacting to see seem to be against this PR - as far as you can trust GH reactions… Once upon a time I also had a |
I'm strongly against this PR. |
On the flip side, people trying nixos might find it highly surprising that it's not there. I think it's just a matter of perspective. For the purity argument, I agree that the NixOS system probably shouldn't have any knowledge of a given user's HOME directory. I guess I don't feel strongly about this. Those that need |
On the other hand, has the ship of non-surprising behaviour not already kinda sailed considering there's effectively no I mean, we have basically two options here:
I feel like considering the circumstances, option 1 would probably be preferable? |
Opting for TL;DR: I'd prefer for this to not be merged. Not having |
Related to the "similar to other distro's" topic is a discussion that already occurred on discourse: https://discourse.nixos.org/t/why-i-switched-to-manjaro-linux/5903/22. If we decide to include such a thing in nixos, people who want a more "batteries-included" experience can opt into importing a "profile", which will create a desktop environment with all the defaults taken from an opinionated distro. E.g:
Edit: this does create the overhead of trying to "keep-up-to-date" with the other distros. But at least for a user, they are able to get a gnome desktop, firefox, and many other applications with just one line instead of many. |
The issue is not what other Linux distros do, it's what NixOS has done for the last decade or so. If you don't want ~/bin to be used, the simple solution is to not have a ~/bin. |
I'll bow to the will of the people and close this PR. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/announcing-determinate-nix/54709/57 |
This reverts commit a06529b. Having
~/bin
in$PATH
has been the case in NixOS since forever or so, so I don't see a strong reason for changing this. People who don't want this can setenvironment.homeBinInPath
to false now.