Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atari800: 4.0.0 -> 4.2.0 #83821

Merged
merged 3 commits into from Apr 7, 2020
Merged

atari800: 4.0.0 -> 4.2.0 #83821

merged 3 commits into from Apr 7, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Mar 31, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ryantm
ryantm requested changes Apr 6, 2020
View reviewed changes
pkgs/misc/emulators/atari800/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/atari800/default.nix Outdated Show resolved Hide resolved
AndersonTorres and others added 2 commits April 6, 2020 12:33
@AndersonTorres @ryantm
Update pkgs/misc/emulators/atari800/default.nix
80c8e2c 
Co-Authored-By: Ryan Mulligan <ryan@ryantm.com>
@AndersonTorres @ryantm
Update pkgs/misc/emulators/atari800/default.nix
1eb523b 
Co-Authored-By: Ryan Mulligan <ryan@ryantm.com>
@ryantm ryantm merged commit 5040cd5 into NixOS:master Apr 7, 2020
@ryantm
Copy link
Member

ryantm commented Apr 7, 2020

Thanks!

@AndersonTorres AndersonTorres deleted the update-atari800 branch November 30, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndersonTorres @ryantm