Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instability in DSP timing fuzzer #1286

Open
mithro opened this issue Mar 31, 2020 · 3 comments
Open

Instability in DSP timing fuzzer #1286

mithro opened this issue Mar 31, 2020 · 3 comments
Assignees
@kgugala

Comments

@mithro
Copy link
Contributor

mithro commented Mar 31, 2020

https://console.cloud.google.com/storage/browser/_details/symbiflow-prjxray/artifacts/prod/foss-fpga-tools/prjxray/presubmit/database/artix7/1386/20200330-090521/database/diff.patch

diff --git a/artix7/timings/DSP_L.sdf b/artix7/timings/DSP_L.sdf
index e23a6ff..4eb87d8 100644
--- a/artix7/timings/DSP_L.sdf
+++ b/artix7/timings/DSP_L.sdf
@@ -260,13 +260,13 @@
         (INSTANCE DSP48E1)
         (DELAY
             (ABSOLUTE
-                (IOPATH A CARRYCASCOUT (0.596::2.268)(1.345::5.400))
-                (IOPATH A CARRYOUT (0.580::2.133)(1.334::5.046))
-                (IOPATH A MULTSIGNOUT (0.592::2.140)(1.323::5.029))
-                (IOPATH A P (0.587::2.142)(1.346::5.070))
-                (IOPATH A PATTERNBDETECT (0.628::2.339)(1.430::5.636))
-                (IOPATH A PATTERNDETECT (0.628::2.339)(1.430::5.636))
-                (IOPATH A PCOUT (0.580::2.133)(1.334::5.046))
+                (IOPATH D CARRYCASCOUT (0.596::2.268)(1.345::5.400))
+                (IOPATH D CARRYOUT (0.580::2.133)(1.334::5.046))
+                (IOPATH D MULTSIGNOUT (0.592::2.140)(1.323::5.029))
+                (IOPATH D P (0.587::2.142)(1.346::5.070))
+                (IOPATH D PATTERNBDETECT (0.628::2.339)(1.430::5.636))
+                (IOPATH D PATTERNDETECT (0.628::2.339)(1.430::5.636))
+                (IOPATH D PCOUT (0.580::2.133)(1.334::5.046))
             )
         )
     )
@@ -275,13 +275,13 @@
         (INSTANCE DSP48E1)
         (DELAY
             (ABSOLUTE
-                (IOPATH A CARRYCASCOUT (0.596::2.268)(1.345::5.400))
-                (IOPATH A CARRYOUT (0.580::2.133)(1.334::5.046))
-                (IOPATH A MULTSIGNOUT (0.592::2.140)(1.323::5.029))
-                (IOPATH A P (0.587::2.142)(1.346::5.070))
-                (IOPATH A PATTERNBDETECT (0.628::2.339)(1.430::5.636))
-                (IOPATH A PATTERNDETECT (0.628::2.339)(1.430::5.636))
-                (IOPATH A PCOUT (0.580::2.133)(1.334::5.046))
+                (IOPATH D CARRYCASCOUT (0.596::2.268)(1.345::5.400))
+                (IOPATH D CARRYOUT (0.580::2.133)(1.334::5.046))
+                (IOPATH D MULTSIGNOUT (0.592::2.140)(1.323::5.029))
+                (IOPATH D P (0.587::2.142)(1.346::5.070))
+                (IOPATH D PATTERNBDETECT (0.628::2.339)(1.430::5.636))
+                (IOPATH D PATTERNDETECT (0.628::2.339)(1.430::5.636))
+                (IOPATH D PCOUT (0.580::2.133)(1.334::5.046))
             )
         )
     )
@@ -289,48 +289,48 @@
         (CELLTYPE "DSP48E1_ADREG_0_DREG_0_MREG_0_PREG_1_USE_DPORT_TRUE_USE_MULT_DYNAMIC_USE_PATTERN_DETECT_NO_PATDET")
         (INSTANCE DSP48E1)
         (TIMINGCHECK
-            (HOLD A (posedge CLK) (-4.951::-0.994))
-            (SETUP A (posedge CLK) (0.994::4.951))
+            (HOLD D (posedge CLK) (-4.951::-0.994))
+            (SETUP D (posedge CLK) (0.994::4.951))
         )
     )
     (CELL
         (CELLTYPE "DSP48E1_ADREG_0_DREG_0_MREG_0_PREG_1_USE_DPORT_TRUE_USE_MULT_DYNAMIC_USE_PATTERN_DETECT_PATDET")
         (INSTANCE DSP48E1)
         (TIMINGCHECK
-            (HOLD A (posedge CLK) (-5.342::-1.063))
-            (SETUP A (posedge CLK) (1.063::5.342))
+            (HOLD D (posedge CLK) (-5.342::-1.063))
+            (SETUP D (posedge CLK) (1.063::5.342))
         )
     )
     (CELL
         (CELLTYPE "DSP48E1_ADREG_0_DREG_0_MREG_0_PREG_1_USE_DPORT_TRUE_USE_MULT_MULTIPLY_USE_PATTERN_DETECT_NO_PATDET")
         (INSTANCE DSP48E1)
         (TIMINGCHECK
-            (HOLD A (posedge CLK) (-4.951::-0.994))
-            (SETUP A (posedge CLK) (0.994::4.951))
+            (HOLD D (posedge CLK) (-4.951::-0.994))
+            (SETUP D (posedge CLK) (0.994::4.951))
         )
     )
     (CELL
         (CELLTYPE "DSP48E1_ADREG_0_DREG_0_MREG_0_PREG_1_USE_DPORT_TRUE_USE_MULT_MULTIPLY_USE_PATTERN_DETECT_PATDET")
         (INSTANCE DSP48E1)
         (TIMINGCHECK
-            (HOLD A (posedge CLK) (-5.342::-1.063))
-            (SETUP A (posedge CLK) (1.063::5.342))
+            (HOLD D (posedge CLK) (-5.342::-1.063))
+            (SETUP D (posedge CLK) (1.063::5.342))
         )
     )
     (CELL
         (CELLTYPE "DSP48E1_ADREG_0_DREG_0_MREG_1_USE_DPORT_TRUE_USE_MULT_DYNAMIC")
         (INSTANCE DSP48E1)
         (TIMINGCHECK
-            (HOLD A (posedge CLK) (-3.158::-0.249))
-            (SETUP A (posedge CLK) (0.249::3.158))
+            (HOLD D (posedge CLK) (-3.158::-0.249))
+            (SETUP D (posedge CLK) (0.249::3.158))
         )
     )
     (CELL
         (CELLTYPE "DSP48E1_ADREG_0_DREG_0_MREG_1_USE_DPORT_TRUE_USE_MULT_MULTIPLY")
         (INSTANCE DSP48E1)
         (TIMINGCHECK
-            (HOLD A (posedge CLK) (-3.158::-0.249))
-            (SETUP A (posedge CLK) (0.249::3.158))
+            (HOLD D (posedge CLK) (-3.158::-0.249))
+            (SETUP D (posedge CLK) (0.249::3.158))
         )
     )
     (CELL
@@ -1835,46 +1835,30 @@
     (CELL
         (CELLTYPE "DSP48E1DREG_1_ADREG_0_DREG_0_MREG_0_PREG_0_USE_DPORT_TRUE_USE_MULT_DYNAMIC")
         (INSTANCE DSP48E1)
-        (DELAY
-            (ABSOLUTE
-                (IOPATH CLK CARRYOUT (0.688::2.241)(1.522::5.297))
-                (IOPATH CLK P (0.696::2.251)(1.533::5.320))
-                (IOPATH CLK PCOUT (0.717::2.334)(1.575::5.515))
-            )
-        )
-    )
-    (CELL
-        (CELLTYPE "DSP48E1DREG_1_ADREG_0_DREG_0_MREG_0_PREG_0_USE_DPORT_TRUE_USE_MULT_MULTIPLY")
-        (INSTANCE DSP48E1)
-        (DELAY
-            (ABSOLUTE
-                (IOPATH CLK CARRYOUT (0.688::2.241)(1.522::5.297))
-                (IOPATH CLK P (0.696::2.251)(1.533::5.320))
-                (IOPATH CLK PCOUT (0.717::2.334)(1.575::5.515))
-            )
-        )
-    )
-    (CELL
-        (CELLTYPE "DSP48E1DREG_1_A_ADREG_0_DREG_0_MREG_0_PREG_0_USE_DPORT_TRUE_USE_MULT_DYNAMIC")
-        (INSTANCE DSP48E1)
         (DELAY
             (ABSOLUTE
                 (IOPATH CLK CARRYCASCOUT (0.705::2.375)(1.531::5.650))
+                (IOPATH CLK CARRYOUT (0.688::2.241)(1.522::5.297))
                 (IOPATH CLK MULTSIGNOUT (0.700::2.248)(1.510::5.279))
+                (IOPATH CLK P (0.696::2.251)(1.533::5.320))
                 (IOPATH CLK PATTERNBDETECT (0.736::2.447)(1.618::5.885))
                 (IOPATH CLK PATTERNDETECT (0.736::2.447)(1.618::5.885))
+                (IOPATH CLK PCOUT (0.717::2.334)(1.575::5.515))
             )
         )
     )
     (CELL
-        (CELLTYPE "DSP48E1DREG_1_A_ADREG_0_DREG_0_MREG_0_PREG_0_USE_DPORT_TRUE_USE_MULT_MULTIPLY")
+        (CELLTYPE "DSP48E1DREG_1_ADREG_0_DREG_0_MREG_0_PREG_0_USE_DPORT_TRUE_USE_MULT_MULTIPLY")
         (INSTANCE DSP48E1)
         (DELAY
             (ABSOLUTE
                 (IOPATH CLK CARRYCASCOUT (0.705::2.375)(1.531::5.650))
+                (IOPATH CLK CARRYOUT (0.688::2.241)(1.522::5.297))
                 (IOPATH CLK MULTSIGNOUT (0.700::2.248)(1.510::5.279))
+                (IOPATH CLK P (0.696::2.251)(1.533::5.320))
                 (IOPATH CLK PATTERNBDETECT (0.736::2.447)(1.618::5.885))
                 (IOPATH CLK PATTERNDETECT (0.736::2.447)(1.618::5.885))
+                (IOPATH CLK PCOUT (0.717::2.334)(1.575::5.515))
             )
         )
     )
diff --git a/artix7/timings/DSP_R.sdf b/artix7/timings/DSP_R.sdf
index e23a6ff..4eb87d8 100644
--- a/artix7/timings/DSP_R.sdf
+++ b/artix7/timings/DSP_R.sdf
@@ -260,13 +260,13 @@
         (INSTANCE DSP48E1)
         (DELAY
             (ABSOLUTE
-                (IOPATH A CARRYCASCOUT (0.596::2.268)(1.345::5.400))
-                (IOPATH A CARRYOUT (0.580::2.133)(1.334::5.046))
-                (IOPATH A MULTSIGNOUT (0.592::2.140)(1.323::5.029))
-                (IOPATH A P (0.587::2.142)(1.346::5.070))
-                (IOPATH A PATTERNBDETECT (0.628::2.339)(1.430::5.636))
-                (IOPATH A PATTERNDETECT (0.628::2.339)(1.430::5.636))
-                (IOPATH A PCOUT (0.580::2.133)(1.334::5.046))
+                (IOPATH D CARRYCASCOUT (0.596::2.268)(1.345::5.400))
+                (IOPATH D CARRYOUT (0.580::2.133)(1.334::5.046))
+                (IOPATH D MULTSIGNOUT (0.592::2.140)(1.323::5.029))
+                (IOPATH D P (0.587::2.142)(1.346::5.070))
+                (IOPATH D PATTERNBDETECT (0.628::2.339)(1.430::5.636))
+                (IOPATH D PATTERNDETECT (0.628::2.339)(1.430::5.636))
+                (IOPATH D PCOUT (0.580::2.133)(1.334::5.046))
             )
         )
     )
@@ -275,13 +275,13 @@
         (INSTANCE DSP48E1)
         (DELAY
             (ABSOLUTE
-                (IOPATH A CARRYCASCOUT (0.596::2.268)(1.345::5.400))
-                (IOPATH A CARRYOUT (0.580::2.133)(1.334::5.046))
-                (IOPATH A MULTSIGNOUT (0.592::2.140)(1.323::5.029))
-                (IOPATH A P (0.587::2.142)(1.346::5.070))
-                (IOPATH A PATTERNBDETECT (0.628::2.339)(1.430::5.636))
-                (IOPATH A PATTERNDETECT (0.628::2.339)(1.430::5.636))
-                (IOPATH A PCOUT (0.580::2.133)(1.334::5.046))
+                (IOPATH D CARRYCASCOUT (0.596::2.268)(1.345::5.400))
+                (IOPATH D CARRYOUT (0.580::2.133)(1.334::5.046))
+                (IOPATH D MULTSIGNOUT (0.592::2.140)(1.323::5.029))
+                (IOPATH D P (0.587::2.142)(1.346::5.070))
+                (IOPATH D PATTERNBDETECT (0.628::2.339)(1.430::5.636))
+                (IOPATH D PATTERNDETECT (0.628::2.339)(1.430::5.636))
+                (IOPATH D PCOUT (0.580::2.133)(1.334::5.046))
             )
         )
     )
@@ -289,48 +289,48 @@
         (CELLTYPE "DSP48E1_ADREG_0_DREG_0_MREG_0_PREG_1_USE_DPORT_TRUE_USE_MULT_DYNAMIC_USE_PATTERN_DETECT_NO_PATDET")
         (INSTANCE DSP48E1)
         (TIMINGCHECK
-            (HOLD A (posedge CLK) (-4.951::-0.994))
-            (SETUP A (posedge CLK) (0.994::4.951))
+            (HOLD D (posedge CLK) (-4.951::-0.994))
+            (SETUP D (posedge CLK) (0.994::4.951))
         )
     )
     (CELL
         (CELLTYPE "DSP48E1_ADREG_0_DREG_0_MREG_0_PREG_1_USE_DPORT_TRUE_USE_MULT_DYNAMIC_USE_PATTERN_DETECT_PATDET")
         (INSTANCE DSP48E1)
         (TIMINGCHECK
-            (HOLD A (posedge CLK) (-5.342::-1.063))
-            (SETUP A (posedge CLK) (1.063::5.342))
+            (HOLD D (posedge CLK) (-5.342::-1.063))
+            (SETUP D (posedge CLK) (1.063::5.342))
         )
     )
     (CELL
         (CELLTYPE "DSP48E1_ADREG_0_DREG_0_MREG_0_PREG_1_USE_DPORT_TRUE_USE_MULT_MULTIPLY_USE_PATTERN_DETECT_NO_PATDET")
         (INSTANCE DSP48E1)
         (TIMINGCHECK
-            (HOLD A (posedge CLK) (-4.951::-0.994))
-            (SETUP A (posedge CLK) (0.994::4.951))
+            (HOLD D (posedge CLK) (-4.951::-0.994))
+            (SETUP D (posedge CLK) (0.994::4.951))
         )
     )
     (CELL
         (CELLTYPE "DSP48E1_ADREG_0_DREG_0_MREG_0_PREG_1_USE_DPORT_TRUE_USE_MULT_MULTIPLY_USE_PATTERN_DETECT_PATDET")
         (INSTANCE DSP48E1)
         (TIMINGCHECK
-            (HOLD A (posedge CLK) (-5.342::-1.063))
-            (SETUP A (posedge CLK) (1.063::5.342))
+            (HOLD D (posedge CLK) (-5.342::-1.063))
+            (SETUP D (posedge CLK) (1.063::5.342))
         )
     )
     (CELL
         (CELLTYPE "DSP48E1_ADREG_0_DREG_0_MREG_1_USE_DPORT_TRUE_USE_MULT_DYNAMIC")
         (INSTANCE DSP48E1)
         (TIMINGCHECK
-            (HOLD A (posedge CLK) (-3.158::-0.249))
-            (SETUP A (posedge CLK) (0.249::3.158))
+            (HOLD D (posedge CLK) (-3.158::-0.249))
+            (SETUP D (posedge CLK) (0.249::3.158))
         )
     )
     (CELL
         (CELLTYPE "DSP48E1_ADREG_0_DREG_0_MREG_1_USE_DPORT_TRUE_USE_MULT_MULTIPLY")
         (INSTANCE DSP48E1)
         (TIMINGCHECK
-            (HOLD A (posedge CLK) (-3.158::-0.249))
-            (SETUP A (posedge CLK) (0.249::3.158))
+            (HOLD D (posedge CLK) (-3.158::-0.249))
+            (SETUP D (posedge CLK) (0.249::3.158))
         )
     )
     (CELL
@@ -1835,46 +1835,30 @@
     (CELL
         (CELLTYPE "DSP48E1DREG_1_ADREG_0_DREG_0_MREG_0_PREG_0_USE_DPORT_TRUE_USE_MULT_DYNAMIC")
         (INSTANCE DSP48E1)
-        (DELAY
-            (ABSOLUTE
-                (IOPATH CLK CARRYOUT (0.688::2.241)(1.522::5.297))
-                (IOPATH CLK P (0.696::2.251)(1.533::5.320))
-                (IOPATH CLK PCOUT (0.717::2.334)(1.575::5.515))
-            )
-        )
-    )
-    (CELL
-        (CELLTYPE "DSP48E1DREG_1_ADREG_0_DREG_0_MREG_0_PREG_0_USE_DPORT_TRUE_USE_MULT_MULTIPLY")
-        (INSTANCE DSP48E1)
-        (DELAY
-            (ABSOLUTE
-                (IOPATH CLK CARRYOUT (0.688::2.241)(1.522::5.297))
-                (IOPATH CLK P (0.696::2.251)(1.533::5.320))
-                (IOPATH CLK PCOUT (0.717::2.334)(1.575::5.515))
-            )
-        )
-    )
-    (CELL
-        (CELLTYPE "DSP48E1DREG_1_A_ADREG_0_DREG_0_MREG_0_PREG_0_USE_DPORT_TRUE_USE_MULT_DYNAMIC")
-        (INSTANCE DSP48E1)
         (DELAY
             (ABSOLUTE
                 (IOPATH CLK CARRYCASCOUT (0.705::2.375)(1.531::5.650))
+                (IOPATH CLK CARRYOUT (0.688::2.241)(1.522::5.297))
                 (IOPATH CLK MULTSIGNOUT (0.700::2.248)(1.510::5.279))
+                (IOPATH CLK P (0.696::2.251)(1.533::5.320))
                 (IOPATH CLK PATTERNBDETECT (0.736::2.447)(1.618::5.885))
                 (IOPATH CLK PATTERNDETECT (0.736::2.447)(1.618::5.885))
+                (IOPATH CLK PCOUT (0.717::2.334)(1.575::5.515))
             )
         )
     )
     (CELL
-        (CELLTYPE "DSP48E1DREG_1_A_ADREG_0_DREG_0_MREG_0_PREG_0_USE_DPORT_TRUE_USE_MULT_MULTIPLY")
+        (CELLTYPE "DSP48E1DREG_1_ADREG_0_DREG_0_MREG_0_PREG_0_USE_DPORT_TRUE_USE_MULT_MULTIPLY")
         (INSTANCE DSP48E1)
         (DELAY
             (ABSOLUTE
                 (IOPATH CLK CARRYCASCOUT (0.705::2.375)(1.531::5.650))
+                (IOPATH CLK CARRYOUT (0.688::2.241)(1.522::5.297))
                 (IOPATH CLK MULTSIGNOUT (0.700::2.248)(1.510::5.279))
+                (IOPATH CLK P (0.696::2.251)(1.533::5.320))
                 (IOPATH CLK PATTERNBDETECT (0.736::2.447)(1.618::5.885))
                 (IOPATH CLK PATTERNDETECT (0.736::2.447)(1.618::5.885))
+                (IOPATH CLK PCOUT (0.717::2.334)(1.575::5.515))
             )
         )
     )
@mithro
Copy link
Contributor Author

mithro commented Mar 31, 2020

@kgugala I was sure we had a bug about this previously?

@kgugala
Copy link
Contributor

kgugala commented Aug 5, 2020

@kgugala I was sure we had a bug about this previously?

We had, but back then DSP timings fuzzing was disabled. I'll take a look on this (or get sb to do it)

@kgugala
Copy link
Contributor

kgugala commented Aug 11, 2020

I cannot reproduce this one with the latest code @mithro is it still happening in kokoro builds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgugala kgugala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mithro @kgugala