Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babashka: Init at 0.0.89 #83886

Closed
wants to merge 1 commit into from
Closed

babashka: Init at 0.0.89 #83886

wants to merge 1 commit into from

Conversation

bennyandresen
Copy link
Contributor

Motivation for this change

a very neat and useful (small) clojure interpreter that has very quick start up times.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mmilata
Copy link
Member

mmilata commented Mar 31, 2020

fyi #80788 #83776

@bennyandresen
Copy link
Contributor Author

doh. Someone already worked on this yesterday.

@AndersonTorres
Copy link
Member

AndersonTorres commented Apr 2, 2020 •
edited

To be honest, your PR is cleaner :)

@bennyandresen bennyandresen mentioned this pull request Apr 3, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bennyandresen @mmilata @AndersonTorres